Closed Bug 1225361 Opened 4 years ago Closed 4 years ago

Use channel.asyncOpen2 in toolkit/components/places/tests/test_bug_411966.html

Categories

(Core :: DOM: Security, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: ckerschb, Assigned: ckerschb)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → mozilla
Blocks: 1182535
Status: NEW → ASSIGNED
Summary: Use channel.asyncOpen2 in it/components/places/tests/test_bug_411966.html → Use channel.asyncOpen2 in toolkit/components/places/tests/test_bug_411966.html
Comment on attachment 8688241 [details] [diff] [review]
bug_1225361_test_bug_411966.patch

Review of attachment 8688241 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/tests/test_bug_411966.html
@@ +27,5 @@
>  
> +        var clickedLinkChannel = NetUtil.newChannel({
> +                                   uri: clickedLinkURI,
> +                                   loadUsingSystemPrincipal: true,
> +                                   securityFlags: Ci.nsILoadInfo.SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL

Might be worth fixing the default here before we convert too many callsites to use NetUtil.newChannel.

Technically it's fine that these callsites continue to explicitly set a flag, but stuff like this tends to get copied around the code since people aren't always aware what they do or don't have to do.
Attachment #8688241 - Flags: review?(jonas) → review+
https://hg.mozilla.org/mozilla-central/rev/3fb056e694bb
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.