Closed
Bug 1225362
Opened 9 years ago
Closed 9 years ago
Use channel.asyncOpen2 in toolkit/components/search/nsSearchService.js
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: ckerschb, Assigned: ckerschb)
References
Details
Attachments
(1 file)
7.01 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8688242 -
Flags: review?(jonas)
Comment on attachment 8688242 [details] [diff] [review] bug_1225362_asyncopen2_nssearchservice.patch Review of attachment 8688242 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/search/nsSearchService.js @@ +877,5 @@ > + return NetUtil.newChannel({ > + uri: url, > + loadUsingSystemPrincipal: true, > + securityFlags: Ci.nsILoadInfo.SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL > + }); This change will no longer be needed, right? @@ +1458,5 @@ > + var chan = NetUtil.newChannel({ > + uri: uri, > + loadUsingSystemPrincipal: true, > + securityFlags: Ci.nsILoadInfo.SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL > + }); And you can drop the securityFlags here, right? @@ +1527,5 @@ > + var chan = NetUtil.newChannel({ > + uri: uri, > + loadUsingSystemPrincipal: true, > + securityFlags: Ci.nsILoadInfo.SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL > + }); And here @@ +1808,5 @@ > + var chan = NetUtil.newChannel({ > + uri: uri, > + loadUsingSystemPrincipal: true, > + securityFlags: Ci.nsILoadInfo.SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL > + }); And here
Attachment #8688242 -
Flags: review?(jonas) → review+
Comment 4•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c91eff1c2734
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•