Closed Bug 1225365 Opened 6 years ago Closed 6 years ago
"ASSERTION: shared String
Buffer in Size Of Including This Must Be Unshared"
1. Load the testcase 2. Quickly click "Measure" in about:memory ###!!! ASSERTION: shared StringBuffer in SizeOfIncludingThisMustBeUnshared: '!IsReadonly()', file xpcom/string/nsSubstring.cpp, line 323
This fixes the problem for me locally. I don't have a good sense if this key should be shareable. The reporter was added in bug 807850 and this is the first sign of a problem with it.
Attachment #8688682 - Flags: review?(bzbarsky)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Comment on attachment 8688682 [details] [diff] [review] Fix assertion in the nsScriptNameSpaceManager memory reporter > I don't have a good sense if this key should be shareable. It's shareable, for sure. Object.getOwnPropertyNames(window) will create external JSStrings backed by the same stringbuffers as these keys. Or enumeration of the window, as in the attached testcase not that I look at it. r=me
Attachment #8688682 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/86a46ffd473a4597230a1f638a6fa798ec81fdaa Bug 1225365 - Fix assertion in the nsScriptNameSpaceManager memory reporter. r=bz.
You need to log in before you can comment on or make changes to this bug.