1225455 - Keyboard shortcuts should work in MediaDocuments if video controls are hidden

Status: UNCONFIRMED

(Toolkit :: Video/Audio Controls, enhancement)

Description

[arni2033]

>>> My Info:   Win7_64, Nightly 45, 32bit, ID 20151116030208, new profile <<<
STR:
1. Open any video by direct link:
>   https://videos.cdn.mozilla.net/uploads/mozillaorg/
2. Right-click the <video>, click "Hide controls"
3. Press Spacebar / Left / Right

Result:       No visible action
Expectations: Shortcuts should operate properly, as said on
> https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly#w_media-shortcuts

Comment 1

[Steffen Wilberg]

Selecting "Hide controls" removes the "controls" attribute from the <video> element.
Video sites can omit the controls attribute if they want to provide their own player, like youtube.

keyHandler : function(event) {
    // Ignore keys when content might be providing its own.
    if (!this.video.hasAttribute("controls"))
      return;
https://dxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/videocontrols.xml#1251

So hiding controls also means disabling keyboard shortcuts. The context menu still works, unless overridden by the page.

Explicitly hiding the controls is pretty useless: They fade out immediately if you move the mouse out of the video, or after 3 seconds if you don't move the mouse. So there's no need to manually hide the controls using the context menu unless you want to prevent the controls from being shown if you move the mouse.

I'd consider removing the "hide controls" context menu item.