1225472 - [Music] Search 'close' button is not localized

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] wilsonpage:1225472 > mozilla-b2g:master

Comment 2

[Wilson Page [:wilsonpage]]

Comment on attachment 8688435 [details] [review]
[gaia] wilsonpage:1225472 > mozilla-b2g:master

This l10n syntax error slipped through.

Comment 3

[Wilson Page [:wilsonpage]]

Comment on attachment 8688435 [details] [review]
[gaia] wilsonpage:1225472 > mozilla-b2g:master

https://github.com/mozilla-b2g/gaia/commit/5bb6cd1ff4191b4e963fb141cb6a5f1530653ecb

Comment 4

[Wilson Page [:wilsonpage]]

Comment on attachment 8688435 [details] [review]
[gaia] wilsonpage:1225472 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: No 'Close' text in search view
[Testing completed]: Y
[Risk to taking this patch] (and alternatives if risky): N
[String changes made]: N

Comment 5

[Wilson Page [:wilsonpage]]

[Blocking Requested - why for this release]:

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] wilsonpage:1225472-v2.5 > mozilla-b2g:v2.5

Comment 7

[Mahendra Potharaju [:mahe]]

Comment on attachment 8688435 [details] [review]
[gaia] wilsonpage:1225472 > mozilla-b2g:master

Minor fix. Please uplift to 2.5

Comment 8

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/e2e8f9659fc0bff170e7b2e3fa90316abdba1e8c for 2.5

Comment 9

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame 2.5&master and Aries KK 2.5&master by the STR in comment 0.

Actual results: The 'Close' text shows normally in search view. (If you change the system language, 'Close' text also shows normally)
See attachment: verified_Flame_master.png
Reproduce rate: 0/10


Device: Flame master_512mb (Pass)
Build ID               20151229150205
Gaia Revision          63c3a57ad9935b9c61057a29ee27a1c6ed6a9e23
Gaia Date              2015-12-29 06:59:53
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9ddf0da90fb3bc1ae29966dc596013fc54a44bd2
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151229.184412
Firmware Date          Tue Dec 29 18:44:26 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master (Pass)
Build ID               20151229105558
Gaia Revision          63c3a57ad9935b9c61057a29ee27a1c6ed6a9e23
Gaia Date              2015-12-29 06:59:53
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9ddf0da90fb3bc1ae29966dc596013fc54a44bd2
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151229.111558
Firmware Date          Tue Dec 29 11:16:06 UTC 2015
Bootloader             s1

Device: Flame 2.5_512mb (Pass)
Build ID               20151223152613
Gaia Revision          8db2cdd9eb9b42932c4dfc86d109b3e46c220809
Gaia Date              2015-12-23 13:30:29
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/6fac3536a96a87185a6415d6ae2c36a85612e863
Gecko Version          44.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151223.143931
Firmware Date          Wed Dec 23 14:39:41 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20151223153111
Gaia Revision          8db2cdd9eb9b42932c4dfc86d109b3e46c220809
Gaia Date              2015-12-23 13:30:29
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/6fac3536a96a87185a6415d6ae2c36a85612e863
Gecko Version          44.0
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151223.144147
Firmware Date          Wed Dec 23 14:41:54 UTC 2015
Bootloader             s1

Comment 10

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_master.png

Comment 11

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame 2.5&master and Aries KK 2.5&master.

STR:
1. Go to Music app and tap the search box.

Actual results: The 'Close' text shows normally in search view. (If you change the system language, 'Close' text also shows normally)
See attachment: verified_Flame_master.png
Reproduce rate: 0/10


Device: Flame master_512mb (Pass)
Build ID               20151229150205
Gaia Revision          63c3a57ad9935b9c61057a29ee27a1c6ed6a9e23
Gaia Date              2015-12-29 06:59:53
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9ddf0da90fb3bc1ae29966dc596013fc54a44bd2
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151229.184412
Firmware Date          Tue Dec 29 18:44:26 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master (Pass)
Build ID               20151229105558
Gaia Revision          63c3a57ad9935b9c61057a29ee27a1c6ed6a9e23
Gaia Date              2015-12-29 06:59:53
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9ddf0da90fb3bc1ae29966dc596013fc54a44bd2
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151229.111558
Firmware Date          Tue Dec 29 11:16:06 UTC 2015
Bootloader             s1

Device: Flame 2.5_512mb (Pass)
Build ID               20151223152613
Gaia Revision          8db2cdd9eb9b42932c4dfc86d109b3e46c220809
Gaia Date              2015-12-23 13:30:29
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/6fac3536a96a87185a6415d6ae2c36a85612e863
Gecko Version          44.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151223.143931
Firmware Date          Wed Dec 23 14:39:41 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20151223153111
Gaia Revision          8db2cdd9eb9b42932c4dfc86d109b3e46c220809
Gaia Date              2015-12-23 13:30:29
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/6fac3536a96a87185a6415d6ae2c36a85612e863
Gecko Version          44.0
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151223.144147
Firmware Date          Wed Dec 23 14:41:54 UTC 2015
Bootloader             s1

Comment 12

[Hema Koka [:hema]]

already landed in 2.5 based on previous comments