Closed
Bug 1225492
Opened 9 years ago
Closed 5 years ago
Listen for paused/resumed events on threadClient, not the target
Categories
(DevTools :: Debugger, defect, P1)
Tracking
(firefox68 fixed)
RESOLVED
FIXED
Firefox 68
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: jlong, Assigned: yulia)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission-m1)
Attachments
(1 file)
This will be cleanup after bug 1132501. Right now the we emit thread-paused and thread-resumed events on the target after attaching the thread. We did this so other tools could listen to those events, and the threadClient might not exist yet. After the above bug though, the threadClient will always exist so we should move those events there. It's a much more appropriate place.
Updated•6 years ago
|
Product: Firefox → DevTools
Comment 1•6 years ago
|
||
paused and resumed events are now fired from ThreadClient right here: https://searchfox.org/mozilla-central/source/devtools/shared/client/thread-client.js#694 This method is being called by low level RDP layer: https://searchfox.org/mozilla-central/source/devtools/shared/client/debugger-client.js#834 This ThreadClient might be a really special one to convert to protocol.js front. We would have to get rid of such hacky code first!! Anyway, what is left to do is to remove the listeners of thread-paused/thread-resumed: https://searchfox.org/mozilla-central/search?q=thread-paused%7Cthread-resumed&case=false®exp=true&path= And instead listen like this: toolbox.threadClient.addListener("paused", ...); toolbox.threadClient.addListener("resumed", ...); Note that bug 1492830 or one of its dependency may put the threadClient on target rather than the toolbox, but I'm expecting this bug to land first.
Updated•6 years ago
|
Summary: Emit paused/resumed events on threadClient, not the target → Listen for paused/resumed events on threadClient, not the target
Updated•6 years ago
|
Whiteboard: dt-fission
Assignee | ||
Updated•6 years ago
|
Blocks: dbg-fission
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → ystartsev
Assignee | ||
Comment 2•5 years ago
|
||
As per the bug description, this removes some old code that relied on the target
re-emitting threadClient events. Now we simply listen to the threadClient events directly.
Updated•5 years ago
|
Attachment #9061300 -
Attachment description: Bug 1225492 - Listen to events on the ThreadClient instead of on the re-emitting them on the target; r=ochameau,jdescottes → Bug 1225492 - Listen to events on the ThreadClient instead of re-emitting them on the target; r=ochameau,jdescottes
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e55213bb470a Listen to events on the ThreadClient instead of re-emitting them on the target; r=jdescottes
Comment 4•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Updated•5 years ago
|
Priority: -- → P1
Updated•4 years ago
|
Whiteboard: dt-fission → dt-fission dt-fission-m1
Updated•3 years ago
|
Whiteboard: dt-fission dt-fission-m1 → dt-fission-m1
You need to log in
before you can comment on or make changes to this bug.
Description
•