1225561 - Don't allow a module to export non-existent local bindings

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: check-unbound-local-exports

While adding tests I realised we don't handle the case where a non-existent variable is exported.  The patch fixes this by adding a check to ModuleBuilder::buildAndInit().

I also renamed that class' methods appendLocalExportEntry() and appendIndirectExportEntry() which both append to exportEntries_ rather than localExportEntries_ and indirectExportEntries_ which might be been expected given the names, and added a new appendLocalExportEntry() which does append to localExportEntries_ after doing the check.

Comment 1

[Shu-yu Guo [:shu]]

Comment on attachment 8688564 [details] [diff] [review]
check-unbound-local-exports

Review of attachment 8688564 [details] [diff] [review]:
-----------------------------------------------------------------

Oops, good catch.

::: js/src/builtin/ModuleObject.cpp
@@ +993,4 @@
>                                   importEntries,
>                                   localExportEntries,
>                                   indirectExportEntries,
>                                   starExportEntries);

Nit: re-line up the rest of the arguments.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/37ba7d6d75a9

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/37ba7d6d75a9