Closed Bug 1225590 Opened 6 years ago Closed 6 years ago
Horizontal keyboard scrolling moves in wrong direction on PRIV by Black
User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0 Build ID: 20151029151421 Steps to reproduce: 1. Using Firefox on a PRIV by BlackBerry, load any page that allows horizontal scrolling (or that allows zooming). I tested with http://www.bbc.com/news. 2. Zoom in if necessary so that horizontal scrolling is allowed. 3. Scroll horizontally using the touch-sensitive keyboard. Actual results: The page scrolling is in the opposite direction from Chrome 46. It's also the opposite direction from the BlackBerry Browser on a BlackBerry Passport. Firefox's scrolling direction is inconsistent with vertical scrolling. When scrolling vertically in Firefox using the touch-sensitive keyboard, an upwards scroll event moves down the page. Expected results: The page should scroll in the same direction as Chrome 46. Just as an upwards scroll event on the keyboard moves down the page, a leftwards scroll event should move right on the page, to match the behavior of touch scrolling on the screen.
OS: Unspecified → Android
Hardware: Unspecified → ARM
This review should go to :jchen
Status: UNCONFIRMED → NEW
Component: Graphics, Panning and Zooming → Keyboards and IME
Ever confirmed: true
Nevermind just looked at the patch and there is PZC code being touched.
Component: Keyboards and IME → Graphics, Panning and Zooming
Comment on attachment 8688609 [details] [diff] [review] Negate both X and Y for mouse wheel scrolling, which matches Android platform behaviour Review of attachment 8688609 [details] [diff] [review]: ----------------------------------------------------------------- Cool, thanks! This was probably never exercised before.
Attachment #8688609 - Flags: review?(bugmail.mozilla) → review+
6 years ago
Comment on attachment 8688609 [details] [diff] [review] Negate both X and Y for mouse wheel scrolling, which matches Android platform behaviour Approval Request Comment [Feature/regressing bug #]: it's been this way for a long time, but only exposed recently on new devices (i.e. BlackBerry PRIV) [User impact if declined]: horizontal scrolling on the PRIV is backwards [Describe test coverage new/current, TreeHerder]: not really [Risks and why]: very low risk; only affects horizontal scrolling for events by "pointer" input types. I don't know of any other device that does this; most mousewheels only do vertical scrolling which is probably we've never hit this before [String/UUID change made/needed]: none
Liam, would you be able to verify that this issue is fixed as expected on the latest Nightly build (11/19)? Thanks!
Looks good! I loaded the latest Nightly (2015-11-20) on PRIV by BlackBerry and confirmed that the horizontal scrolling direction is now as expected. It's now consistent with Chrome 46 and with scrolling on the touchscreen.
Comment on attachment 8688609 [details] [diff] [review] Negate both X and Y for mouse wheel scrolling, which matches Android platform behaviour Manual testing on nightly, sounds good for us to support this platform. Please uplift to aurora and beta.
You need to log in before you can comment on or make changes to this bug.