1225590 - Horizontal keyboard scrolling moves in wrong direction on PRIV by BlackBerry

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Liam Quinn]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20151029151421

Steps to reproduce:

1. Using Firefox on a PRIV by BlackBerry, load any page that allows horizontal scrolling (or that allows zooming). I tested with http://www.bbc.com/news.
2. Zoom in if necessary so that horizontal scrolling is allowed.
3. Scroll horizontally using the touch-sensitive keyboard.


Actual results:

The page scrolling is in the opposite direction from Chrome 46. It's also the opposite direction from the BlackBerry Browser on a BlackBerry Passport.

Firefox's scrolling direction is inconsistent with vertical scrolling. When scrolling vertically in Firefox using the touch-sensitive keyboard, an upwards scroll event moves down the page.


Expected results:

The page should scroll in the same direction as Chrome 46. Just as an upwards scroll event on the keyboard moves down the page, a leftwards scroll event should move right on the page, to match the behavior of touch scrolling on the screen.

Comment 1

[Andy Chen]

Attachment: Negate both X and Y for mouse wheel scrolling, which matches Android platform behaviour

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

This review should go to :jchen

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

Nevermind just looked at the patch and there is PZC code being touched.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8688609 [details] [diff] [review]
Negate both X and Y for mouse wheel scrolling, which matches Android platform behaviour

Review of attachment 8688609 [details] [diff] [review]:
-----------------------------------------------------------------

Cool, thanks! This was probably never exercised before.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/f0a2bd881cb7

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f0a2bd881cb7

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8688609 [details] [diff] [review]
Negate both X and Y for mouse wheel scrolling, which matches Android platform behaviour

Approval Request Comment
[Feature/regressing bug #]: it's been this way for a long time, but only exposed recently on new devices (i.e. BlackBerry PRIV)
[User impact if declined]: horizontal scrolling on the PRIV is backwards
[Describe test coverage new/current, TreeHerder]: not really
[Risks and why]: very low risk; only affects horizontal scrolling for events by "pointer" input types. I don't know of any other device that does this; most mousewheels only do vertical scrolling which is probably we've never hit this before
[String/UUID change made/needed]: none

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Liam, would you be able to verify that this issue is fixed as expected on the latest Nightly build (11/19)? Thanks!

Comment 9

[Liam Quinn]

Looks good! I loaded the latest Nightly (2015-11-20) on PRIV by BlackBerry and confirmed that the horizontal scrolling direction is now as expected. It's now consistent with Chrome 46 and with scrolling on the touchscreen.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8688609 [details] [diff] [review]
Negate both X and Y for mouse wheel scrolling, which matches Android platform behaviour

Manual testing on nightly, sounds good for us to support this platform. Please uplift to aurora and beta.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Thanks all!

https://hg.mozilla.org/releases/mozilla-aurora/rev/1802aa83ee3d
https://hg.mozilla.org/releases/mozilla-beta/rev/1fa574fe440e