Closed Bug 1225595 Opened 9 years ago Closed 9 years ago

Migrate from Tower to Puente

Categories

(support.mozilla.org :: Localization, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mythmon, Assigned: rehandalal+mozilla)

References

Details

(Whiteboard: u=dev p=3)

Tower has some problems with Django 1.8, the future, and it isn't good at getting over rivers.

Puente is new, and designed to fix all the problems with Tower. Plus, it goes over a river.

This bug covers switching removing Tower from Sumo and replacing it with Puente.

There is a migration guide for Tower to Puente here: https://puente.readthedocs.org/en/latest/migratingfromtower.html
See Also: → 1173479
Depends on: 1225606
Status: NEW → ASSIGNED
Whiteboard: u=dev p=? → u=dev p=3
this is on -dev. it affects every single part of the site so poking around and doing some QA to make sure nothing broke and that translations work as expected would be good.
Flags: needinfo?(rbillings)
I just tested a wide swatch of functionality on dev, both on mobile + desktop. Including: adding/editing/deleting data, registration, checking locales, links, different activities in forums. I did see a few errors, and they all came through on sentry.
Flags: needinfo?(rbillings)
This sentry Error seems to be related to the Puente change: https://sentry.prod.mozaws.net/operations/sumo-dev/group/159961/

The stack trace is 

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "newrelic/hooks/framework_django.py", line 497, in wrapper
    return wrapped(*args, **kwargs)
  File "django/views/decorators/http.py", line 41, in inner
    return func(request, *args, **kwargs)
  File "kitsune/dashboards/views.py", line 210, in aggregated_metrics
    'products': Product.objects.filter(visible=True),
  File "django/shortcuts.py", line 50, in render
    return HttpResponse(loader.render_to_string(*args, **kwargs),
  File "django/template/loader.py", line 178, in render_to_string
    return t.render(context_instance)
  File "jingo/__init__.py", line 98, in render
    return super(Template, self).render(context_dict)
  File "newrelic/api/function_trace.py", line 98, in dynamic_wrapper
    return wrapped(*args, **kwargs)
  File "jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)
  File "/data/www/support-dev.allizom.org/kitsune/kitsune/dashboards/templates/dashboards/aggregated_metrics.html", line 10, in top-level template code
    {% set product_slug = product.slug if product else 'null' %}
  File "/data/www/support-dev.allizom.org/kitsune/kitsune/sumo/templates/base.html", line 187, in top-level template code
    {% block content %}{% endblock %}
  File "/data/www/support-dev.allizom.org/kitsune/kitsune/dashboards/templates/dashboards/aggregated_metrics.html", line 26, in block "content"
    <h2>{{ _('Top 100 Articles: % Localized') }}</h2>
  File "jinja2/ext.py", line 127, in _gettext_alias
    return __context.call(__context.resolve('gettext'), *args, **kwargs)
  File "jinja2/ext.py", line 136, in gettext
    return rv % variables
  File "jinja2/_markupsafe/__init__.py", line 98, in __mod__
    return self.__class__(unicode.__mod__(self, arg))
All articles have unescaped share text, repros on dev/stage and not on prod:

example: https://support-dev.allizom.org/en-US/kb/get-help-webmaker-android

Share this article: <a href="http://mzl.la/1VOUaAQ">http://mzl.la/1VOUaAQ</a>
Landed:
https://github.com/mozilla/kitsune/commit/f903ec269cbbbf5d32dd95db7e705cf2a5812e71
https://github.com/mozilla/kitsune/commit/9550a2015c4b8389c09477f8db4b347c1201c7d2

Pushed to prod by me, right now.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.