44 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
The only reason for using the CACHE_MIDDLEAWARE_FILES setting in the crashstats/models.py <-> middleware is if you're running with a very volatile cache backend (i.e. locmen). Then the fs can back you up as the cache gets reset repeatedly and frequently. Another use case with the CACHE_MIDDLEWARE_FILES is so you can edit the .json files to see what would happen if the middleware responded very differently.
On the other hand the CACHE_MIDDLEWARE setting ought to always be on. There's really no good default reason for having it off. https://github.com/mozilla/socorro/blob/e3e0bcb52c00536d1e569b2f7665e7083aa7eb9b/webapp-django/crashstats/settings/base.py#L506-L509
Created attachment 8688622 [details] [review] Link to Github pull-request: https://github.com/mozilla/socorro/pull/3098
As mentioned in the comment here: https://github.com/mozilla/socorro/pull/3098#issue-117445070 Once that PR lands we can't close this bug till we check our consul values in stage and prod.
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/806db528792b4f78145eeefdacacdc650559e9a8 bug 1225602 - CACHE_MIDDLEWARE_FILES should be off by default https://github.com/mozilla/socorro/commit/dbcbc0787d8dd66dcb9248e78e0d42cd50101c3d Merge pull request #3098 from peterbe/bug-1225602-cache_middleware_files-should-be-off-by-default bug 1225602 - CACHE_MIDDLEWARE_FILES should be off by default
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.