CACHE_MIDDLEWARE_FILES should be off by default

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: peterbe, Assigned: peterbe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The only reason for using the CACHE_MIDDLEAWARE_FILES setting in the crashstats/models.py <-> middleware is if you're running with a very volatile cache backend (i.e. locmen). Then the fs can back you up as the cache gets reset repeatedly and frequently. Another use case with the CACHE_MIDDLEWARE_FILES is so you can edit the .json files to see what would happen if the middleware responded very differently.
(Assignee)

Comment 1

3 years ago
On the other hand the CACHE_MIDDLEWARE setting ought to always be on. There's really no good default reason for having it off. 

https://github.com/mozilla/socorro/blob/e3e0bcb52c00536d1e569b2f7665e7083aa7eb9b/webapp-django/crashstats/settings/base.py#L506-L509
(Assignee)

Updated

3 years ago
Assignee: nobody → peterbe
(Assignee)

Comment 3

3 years ago
As mentioned in the comment here: https://github.com/mozilla/socorro/pull/3098#issue-117445070
Once that PR lands we can't close this bug till we check our consul values in stage and prod.

Comment 4

3 years ago
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/806db528792b4f78145eeefdacacdc650559e9a8
bug 1225602 - CACHE_MIDDLEWARE_FILES should be off by default

https://github.com/mozilla/socorro/commit/dbcbc0787d8dd66dcb9248e78e0d42cd50101c3d
Merge pull request #3098 from peterbe/bug-1225602-cache_middleware_files-should-be-off-by-default

bug 1225602 - CACHE_MIDDLEWARE_FILES should be off by default
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.