Closed Bug 1225606 Opened 9 years ago Closed 8 years ago

Make our template system work with Django 1.8

Categories

(support.mozilla.org :: Code Quality, task)

Product:
support.mozilla.org
Component:
Code Quality
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mythmon, Unassigned)

References

Details

(Whiteboard: u=dev p=?) 

Our current version of Jingo (which is somewhere around 0.6-ish) doesn't support Django 1.8. Newer versions of Jingo (0.7+) support Django 1.8. Most other projects switched off of Jingo to the more mainstream django-jinja.

Both solutions would probably work for us, except one large issue. The way django-jinja works with Django 1.7 is different from the way it works with Django 1.8. This means that to use django-jinja we effectively have to update it at the same time as we update Django 1.8. That creates more work and more risk.

I propose we stay with Jingo and update to version 0.7 to get Django 1.8 compatibility. In the future we may switch to django-jinja. If switching to Jingo 0.7 is prohibitively hard, we may use django-jinja anyways.
Correction: Jingo 0.8 is the version that added support for Django 1.8. It claims to support both Django 1.7 and Django 1.8, which is what we want.
In the migration of localization tool, the jingo was updated to 0.8.2.
Thanks Rehan.
https://github.com/mozilla/kitsune/pull/2735
So according to conversation over IRC, we are moving from jingo to Django-jinja while Django 1.8 upgrade.
This happened at the same time as the Django 1.8 upgrade in PR: https://github.com/mozilla/kitsune/pull/2785
This is on production now.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.