Closed
Bug 1225700
Opened 9 years ago
Closed 9 years ago
Configure the default build flag FIREFOX_SYNC for different form factor.
Categories
(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P3)
Tracking
(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)
RESOLVED
FIXED
| blocking-b2g | 2.5+ |
People
(Reporter: selee, Unassigned)
References
Details
(Whiteboard: [partner-cherry-pick])
Attachments
(2 files)
In master branch, FIREFOX sync feature will be disabled by default, but the build command still can override the configurations.
|
||
Comment 1•9 years ago
|
||
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8688791 [details] [review] [gaia] weilonge:seanlee/DataSync/master/Bug1225700 > mozilla-b2g:master Hi Ricky, The patch fixes the bug that build command can not override FIREFOX_SYNC flag issue. Could you help to view it? Thank you.
Attachment #8688791 -
Flags: review?(rchien)
|
||
Updated•9 years ago
|
Attachment #8688791 -
Flags: review?(rchien) → review+
|
|
Reporter | |
Updated•9 years ago
|
Summary: Configure the default build flag FIREFOX_SYNC build flag for different form factor. → Configure the default build flag FIREFOX_SYNC for different form factor.
|
|
Reporter | |
Comment 3•9 years ago
|
||
landed on master: https://github.com/mozilla-b2g/gaia/commit/90f51d266adb6f1ee30686ff049140b791e75fb5 gaia-test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=b157668840e1a896e93df60cda1349971c8535ca
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•9 years ago
|
Blocks: TV_FxAccount
|
|
||
Comment 4•9 years ago
|
||
|
|
Reporter | |
Comment 5•9 years ago
|
||
Comment on attachment 8689553 [details] [review] [gaia] weilonge:seanlee/DataSync/v2.5/Bug1225700 > mozilla-b2g:v2.5 [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Bug 1194108 [User impact] if declined: The build command can not override FIREFOX_SYNC build flag. [Testing completed]: Tested on B2G desktop and Mulet [Risk to taking this patch] (and alternatives if risky): none [String changes made]: none
Attachment #8689553 -
Flags: approval-gaia-v2.5?
|
|
Reporter | |
Updated•9 years ago
|
Whiteboard: [partner-cherry-pick]
|
||
Updated•9 years ago
|
blocking-b2g: --- → 2.5+
|
|
||
Updated•9 years ago
|
status-b2g-v2.5:
--- → affected
status-b2g-master:
--- → fixed
|
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8689553 [details] [review] [gaia] weilonge:seanlee/DataSync/v2.5/Bug1225700 > mozilla-b2g:v2.5 Approved as this is required for TV 2.5 datasync
Attachment #8689553 -
Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
|
||
Comment 7•9 years ago
|
||
landed on 2.5 as https://github.com/mozilla-b2g/gaia/commit/a70d47cd78aaaaf06aa131ec9826d3ec2468cbd0
You need to log in
before you can comment on or make changes to this bug.
Description
•