Closed Bug 1225734 Opened 10 years ago Closed 10 years ago

TV simulator should not timeout

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- fixed
b2g-master --- fixed

People

(Reporter: jcheng, Assigned: mantaroh)

References

Details

Attachments

(1 file, 1 obsolete file)

[gaia] mantaroh:master > mozilla-b2g:master
46 bytes, text/x-github-pull-request
jj.evelyn
: review+
jocheng
: approval-gaia-v2.5+
Details | Review
TV simulator times out after some time and shows a black screen. this is confusing
Blocks: 1201451
I think that SCREEN_TIMEOUT value is not 0 in Makefile. I created the PR which modifying the Makefile.
Attachment #8689319 - Flags: review?(ehung)
Comment on attachment 8689319 [details] [review] [gaia] mantaroh:master > mozilla-b2g:master Thanks for your patch, Mantaroh. I prefer to set as a default setting for TV in <gaia>/build/config/tv/settings.json with |"screen.timeout": 0|.
Attachment #8689319 - Flags: review?(ehung)
Assignee: nobody → mantaroh
Attachment #8689319 - Attachment is obsolete: true
Comment on attachment 8691177 [details] [review] [gaia] mantaroh:master > mozilla-b2g:master Thanks Evelyn. (In reply to Evelyn Hung [:evelyn] from comment #3) > Thanks for your patch, Mantaroh. I prefer to set as a default setting for TV > in <gaia>/build/config/tv/settings.json with |"screen.timeout": 0|. OK. I modified the PR.
Attachment #8691177 - Flags: review?(ehung)
Comment on attachment 8691177 [details] [review] [gaia] mantaroh:master > mozilla-b2g:master LGTM. Thanks!
Attachment #8691177 - Flags: review?(ehung) → review+
Merged into master: https://github.com/mozilla-b2g/gaia/commit/6caaaff1591835c5fcd75a4fcc7bb04bf22d980c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8691177 [details] [review] [gaia] mantaroh:master > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): TV enter sleep mode automatically on 2.5 based build [User impact] if declined: Cannot operate TV [Testing completed]: N/A [Risk to taking this patch] (and alternatives if risky): N/A [String changes made]: N/A
Attachment #8691177 - Flags: approval-gaia-v2.5?(jocheng)
blocking-b2g: --- → 2.5+
status-b2g-v2.5: --- → affected
status-b2g-master: --- → fixed
Comment on attachment 8691177 [details] [review] [gaia] mantaroh:master > mozilla-b2g:master Approve for TV 2.5
Attachment #8691177 - Flags: approval-gaia-v2.5?(jocheng) → approval-gaia-v2.5+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: