Closed Bug 1225779 Opened 7 years ago Closed 7 years ago

Deal properly with delegated events

Categories

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: MakeMyDay, Assigned: MakeMyDay)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This bug is about to deal with incoming delegations properly. Delegating event participation to other attendees will be left to bug 420516.
This patch implements mainly more verbose information about delegation and a prefed option to notify the delegator when replying to the organizer.
Attachment #8697812 - Flags: review?(philipp)
Comment on attachment 8697812 [details] [diff] [review]
HandleDelegatedEvents-V1.diff

Review of attachment 8697812 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/base/modules/calUtils.jsm
@@ +337,5 @@
> +     * @param aAttendee  {calIAttendee}  The attendee to resolve the delegation information for
> +     * @param aAttendees {Array}         An array of calIAttendee objects to look up
> +     * @return           {Object}        An object with string attributes for delegators and delegatees
> +     */
> +    resolveDelegation: function (aAttendee, aAttendees) {

Does it make sense to move this to calItipUtils?

::: calendar/base/modules/calItipUtils.jsm
@@ +638,5 @@
> +                        if (Array.isArray(delegatorIds)) {
> +                            for (let delegatorId of delegatorIds) {
> +                                getDelegator(delegatorId);
> +                            }
> +                        } else if (typeof d == "string") {

Might be because of missing context, but where does |d| come from?
Attachment #8697812 - Flags: review?(philipp) → review+
> Does it make sense to move this to calItipUtils?

I think it can reside at either place, but I tend to calUtils.jsm, because this is not specificly for sending but interpreting the event itself.

> Might be because of missing context, but where does |d| come from?

Good catch. This must be delegatorIds.


https://hg.mozilla.org/comm-central/rev/43589f5578b7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.7
You need to log in before you can comment on or make changes to this bug.