1225782 - Remove GlobalPropertiesAreOwn().

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Code: https://mxr.mozilla.org/mozilla-central/search?string=GlobalPropertiesAreOwn

This was added in bug 1005898 to make it easier to turn off the new behaviour, but we haven't needed to turn it off in the year and a half since, so it should be safe to remove.

Comment 1

[Sunny Sidhu]

Attachment: rev1 - Remove GlobalPropertiesAreOwn().

Hi,

I'm new to this. I've attempted to solve this bug, please see attached.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8689146 [details] [diff] [review]
rev1 - Remove GlobalPropertiesAreOwn().

Review of attachment 8689146 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch! I think I discovered one mistake below:

::: dom/bindings/BindingUtils.cpp
@@ +1738,5 @@
>        return false;
>      }
>    }
>  
> +  return (type == eGlobalInterfacePrototype) ||

I'd remove the parentheses here.

::: dom/bindings/Codegen.py
@@ +3669,5 @@
>          self.descriptor = descriptor
>          self.properties = properties
>  
>      def definition_body(self):
> +        properties = "nullptr"

I think you got the condition backwards here.

Comment 3

[Sunny Sidhu]

Attachment: rev2 - Remove GlobalPropertiesAreOwn()

Thank you for the feedback. Please find my revised patch attached.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8689692 [details] [diff] [review]
rev2 - Remove GlobalPropertiesAreOwn()

Review of attachment 8689692 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you, this looks great to me. Asking bz to do the final review.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8689692 [details] [diff] [review]
rev2 - Remove GlobalPropertiesAreOwn()

r=me

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

This should be a simple refactoring; I am fairly confident no try run is necessary.

NOTE: commit message should be updated to say r=bz.

Thanks!

Comment 7

[Sunny Sidhu]

Attachment: rev2.1 - Remove GlobalPropertiesAreOwn()

Thank you!

Hi Boris, please find my patch attached.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8690167 [details] [diff] [review]
rev2.1 - Remove GlobalPropertiesAreOwn()

r=me, but in general no need for more rounds of review on commit message tweaks.  ;)

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/57f738fb6ab6

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/57f738fb6ab6