1225788 - Runtime crash while handling write/read request on local BluetoothGattServer.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Bruce Sun [:brsun]]

|mRequest.Put|[1] would experience a "Logic flaw in the caller" runtime crash if one duplicated request id is going to be put in |mRequest|.

[1] https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/common/webapi/BluetoothGattServer.cpp#235
[2] https://dxr.mozilla.org/mozilla-central/source/xpcom/base/nsAutoPtr.h#37

Comment 1

[Bruce Sun [:brsun]]

Attachment: bug1225788_bluetooth_runtime_crash_read_write_request.patch

Comment 2

[Jocelyn Liu [:jocelyn] [:joliu]]

Comment on attachment 8689375 [details] [diff] [review]
bug1225788_bluetooth_runtime_crash_read_write_request.patch

Review of attachment 8689375 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/common/webapi/BluetoothGattServer.cpp
@@ +231,5 @@
>    // Save the request information for sending the response later
> +  if (mRequestMap.Get(requestId, nullptr)) {
> +    BT_WARNING("Duplicated request id: %d", requestId);
> +    mRequestMap.Remove(requestId);
> +  }

When will this happen?
Why do we choose to remove the existing entry?

BTW, I think we might also need to remove requests when connection drops.

Comment 3

[Jocelyn Liu [:jocelyn] [:joliu]]

Set Bruce as the assignee since he's actively working on this bug.

Comment 4

[Bruce Sun [:brsun]]

Unassign myself due to not working on this issue currently.

Comment 5

[BMO Automation]

Firefox OS is not being worked on