1225809 - unpinning DataStore operation is unsafe

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Michiel de Jong [:michielbdejong]]

The only place where the Homescreen apps writes to the places DataStore seems to be here: https://mxr.mozilla.org/gaia/source/apps/homescreen/js/pages.js#223

Other apps that have write permission to the places DataStore are System and (if enabled) Sync.

If either of those update the same record at the same time, this operation is not safe against race conditions (it does not check whether the DataStore revisionId changed between the `get` and the `put` operation).

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] michielbdejong:1225809-unpinning > mozilla-b2g:master

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] michielbdejong:1225809-safer-unpinning-code > mozilla-b2g:master

Comment 3

[Michiel de Jong [:michielbdejong]]

Comment on attachment 8690073 [details] [review]
[gaia] michielbdejong:1225809-unpinning > mozilla-b2g:master

Obsoleted by https://bugzilla.mozilla.org/attachment.cgi?id=8694175&action=edit

Comment 4

[Chris Lord [:cwiiis]]

Comment on attachment 8694175 [details] [review]
[gaia] michielbdejong:1225809-safer-unpinning-code > mozilla-b2g:master

Couple of nits/questions, but lgtm, thanks!

Comment 5

[BMO Automation]

Firefox OS is not being worked on