Closed
Bug 1225821
Opened 9 years ago
Closed 9 years ago
Add type write barrier to SetPropertyIC dense element stub
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
13.21 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
With this dynamic type barrier in place, we can use the SetPropertyIC for SETELEM with int32 indexes, even if type information is bad. This improves the Emscripten benchmark in bug 1205427 from 9.2 to 1.4 seconds and I think/hope it will also fix bug 1225311.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8688948 -
Flags: review?(bhackett1024)
|
||
Updated•9 years ago
|
Attachment #8688948 -
Flags: review?(bhackett1024) → review+
|
||
Comment 3•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/769ffacadef5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
|
||
Comment 5•8 years ago
|
||
(also fixed PDF.js performance for some large scanned documents, see https://github.com/mozilla/pdf.js/issues/6977#issuecomment-183422772)
You need to log in
before you can comment on or make changes to this bug.
Description
•