1225843 - [TV][2.5][Browser][New Strings] Please add hyperlinks for "Terms of Service" and "Privacy Notice"

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P2)

Description

[Cynthia Tang [:cynthiatang]]

STR:
 1. Launch Browser
 2. Go to Menu > Select "Sign in to Sync"

Actual result:
 - The string is correct. "By proceeding, I agree to the Terms of Service and Privacy Notice of Firefox cloud services."
 - But there is no hyperlinks for "Terms of Service" and "Privacy Notice"

Comment 1

[Josh Cheng [:josh]]

Hi YiFan, Hi Dan,
Is it possible for user to click and browse "Terms of Service" and "Privacy Notice" link in browser

Comment 2

[Sean Lee [:seanlee][:weilonge]]

The links for these two items:

"Terms of Service" : https://accounts.firefox.com/legal/terms
  "Privacy Notice" : https://accounts.firefox.com/legal/privacy

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/TVBrowser/master/Bug1225843 > mozilla-b2g:master

Comment 4

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8691756 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1225843 > mozilla-b2g:master

Hey Yifan, could you help to review this patch? thanks!

Comment 5

[yifan [:yifan][:yliao]]

Comment on attachment 8691756 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1225843 > mozilla-b2g:master

LGTM! Thank you!

Comment 6

[Sean Lee [:seanlee][:weilonge]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/fff2e947e8212f28833ef9d201843ccad16f3fd2
gaia-test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=6fd8131d2b222579b9af27882af0b2fb4f5774fe

Comment 7

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8691756 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1225843 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1223379
[User impact] if declined: The link of "Terms of Service" and "Privacy Notice" can not be clicked.
[Testing completed]: Test on b2g desktop
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 8

[Josh Cheng [:josh]]

Comment on attachment 8691756 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1225843 > mozilla-b2g:master

Approve for TV Browser 2.5

Comment 9

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/52441c0c2f70452678aabbe7116ae901549a4304

Comment 10

[Cynthia Tang [:cynthiatang]]

Verified on 

Branch master
commit ff662257263e9d71f8202d9d61a1b2035944e346
Merge: af7fe55 ae5cbee
Author: Johan Lorenzo <[e-mail]>
Date:   Fri Dec 4 12:26:37 2015 +0100

Branch v2.5
Commit 2d54c29f429bed790b5d8284633812dc2b782518
Author: Fischer.json <[e-mail]>
Date:   Mon Nov 30 15:06:13 2015 +0800