Closed
Bug 1225843
Opened 9 years ago
Closed 9 years ago
[TV][2.5][Browser][New Strings] Please add hyperlinks for "Terms of Service" and "Privacy Notice"
Categories
(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P2)
Tracking
(blocking-b2g:2.5+, b2g-v2.5 verified, b2g-master verified)
VERIFIED
FIXED
| blocking-b2g | 2.5+ |
People
(Reporter: cynthiatang, Assigned: selee)
References
Details
(Whiteboard: [ft:conndevices][partner-blocker][partner-cherry-pick])
Attachments
(1 file)
|
46 bytes,
text/x-github-pull-request
|
yifan
:
review+
jocheng
:
approval-gaia-v2.5+
|
Details | Review |
STR: 1. Launch Browser 2. Go to Menu > Select "Sign in to Sync" Actual result: - The string is correct. "By proceeding, I agree to the Terms of Service and Privacy Notice of Firefox cloud services." - But there is no hyperlinks for "Terms of Service" and "Privacy Notice"
|
Reporter | |
Updated•9 years ago
|
QA Whiteboard: [COM=TV Firefox Account]
|
||
Comment 1•9 years ago
|
||
Hi YiFan, Hi Dan, Is it possible for user to click and browse "Terms of Service" and "Privacy Notice" link in browser
blocking-b2g: --- → 2.5+
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → selee
|
|
Assignee | |
Comment 2•9 years ago
|
||
The links for these two items: "Terms of Service" : https://accounts.firefox.com/legal/terms "Privacy Notice" : https://accounts.firefox.com/legal/privacy
|
||
Comment 3•9 years ago
|
||
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8691756 [details] [review] [gaia] weilonge:seanlee/TVBrowser/master/Bug1225843 > mozilla-b2g:master Hey Yifan, could you help to review this patch? thanks!
Attachment #8691756 -
Flags: review?(yliao)
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8691756 [details] [review] [gaia] weilonge:seanlee/TVBrowser/master/Bug1225843 > mozilla-b2g:master LGTM! Thank you!
Attachment #8691756 -
Flags: review?(yliao) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
landed on master: https://github.com/mozilla-b2g/gaia/commit/fff2e947e8212f28833ef9d201843ccad16f3fd2 gaia-test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=6fd8131d2b222579b9af27882af0b2fb4f5774fe
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•9 years ago
|
||
Comment on attachment 8691756 [details] [review] [gaia] weilonge:seanlee/TVBrowser/master/Bug1225843 > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): bug 1223379 [User impact] if declined: The link of "Terms of Service" and "Privacy Notice" can not be clicked. [Testing completed]: Test on b2g desktop [Risk to taking this patch] (and alternatives if risky): none [String changes made]: none
Attachment #8691756 -
Flags: approval-gaia-v2.5?
|
|
||
Updated•9 years ago
|
status-b2g-v2.5:
--- → affected
status-b2g-master:
--- → fixed
|
|
||
Comment 8•9 years ago
|
||
Comment on attachment 8691756 [details] [review] [gaia] weilonge:seanlee/TVBrowser/master/Bug1225843 > mozilla-b2g:master Approve for TV Browser 2.5
Attachment #8691756 -
Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
|
||
Comment 9•9 years ago
|
||
for 2.5 https://github.com/mozilla-b2g/gaia/commit/52441c0c2f70452678aabbe7116ae901549a4304
|
|
Reporter | |
Comment 10•9 years ago
|
||
Verified on Branch master commit ff662257263e9d71f8202d9d61a1b2035944e346 Merge: af7fe55 ae5cbee Author: Johan Lorenzo <jlorenzo@mozilla.com> Date: Fri Dec 4 12:26:37 2015 +0100 Branch v2.5 Commit 2d54c29f429bed790b5d8284633812dc2b782518 Author: Fischer.json <foxbrush@Fischerjsons-MacBook-Pro.local> Date: Mon Nov 30 15:06:13 2015 +0800
You need to log in
before you can comment on or make changes to this bug.
Description
•