1225903 - Drop support for b2g desktop in mochitest

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Andrew Halberstadt [:ahal]]

We no longer run mochitests or reftest on b2g desktop for any trunk branches, including b2g-inbound.

There is considerable hackiness in both of these harnesses to support b2g desktop. Dropping support would decrease a lot of complexity and increase maintainability, and I think is well worth the minor effort to do this.

Dropping support will also discourage developers from running b2g desktop locally (I assume this is a good thing). I'm filing this because if we don't drop support, I'm going to have to do some extra work due to bug 1219442.

Comment 1

[Andrew Halberstadt [:ahal]]

Just going to tackle mochitest for now, as mulet and b2g_desktop actually share a lot of code in reftest for some reason (so it's not as easy to simply gut b2g desktop). I'll file a follow-up for reftest, though may punt on working on it.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: Bug 1225903 - Drop support for b2g desktop in mochitest, r=jgriffin

Bug 1225903 - Drop support for b2g desktop in mochitest, r=jgriffin

B2G desktop is no longer being run on any trunk branches, including
b2g-inbound. Dropping support for it significantly reduces complexity
in the mochitest harness.

Comment 3

[Andrew Halberstadt [:ahal]]

Here's some working try runs:
https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&fromchange=2c2fbf78ff54&tochange=15c8b2c0b83f

The diff makes the changes look more complicated than they are. All that happened in runtests.py was to rename MochitestUtilsMixin -> MochitestBase, rename Mochitest -> MochitestDesktop, and move some functions that b2g uses out of MochitestDesktop and into MochitestBase.

In runtestsb2g, all that happened was B2GDesktopMochitest got deleted, and B2GDeviceMochitest got merged with B2GMochitest.

Comment 4

[Andrew Halberstadt [:ahal]]

Also forgot to mention I talked to gwagner on irc and got the green light for this.

Comment 5

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8689526 [details]
MozReview Request: Bug 1225903 - Drop support for b2g desktop in mochitest, r=jgriffin

https://reviewboard.mozilla.org/r/25657/#review23109

Yay for deleting dead code.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ab228593820

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for apparently breaking robocop on android: https://treeherder.mozilla.org/logviewer.html#?job_id=17553901&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/d69c0607d8b1

Comment 8

[Andrew Halberstadt [:ahal]]

Sorry about that. I didn't realize robocop got pulled out of runtestsremote.py and completely missed the new runrobocop.py file and then robocop didn't get selected by '-u mochitests' on try. Here's a try run that should have the issue fixed:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=47a217067ba1

Comment 9

[Andrew Halberstadt [:ahal]]

Comment on attachment 8689526 [details]
MozReview Request: Bug 1225903 - Drop support for b2g desktop in mochitest, r=jgriffin

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25657/diff/1-2/

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/18344b1eb183

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/18344b1eb183