Closed Bug 1225903 Opened 4 years ago Closed 4 years ago
Drop support for b2g desktop in mochitest
40 bytes, text/x-review-board-request
We no longer run mochitests or reftest on b2g desktop for any trunk branches, including b2g-inbound. There is considerable hackiness in both of these harnesses to support b2g desktop. Dropping support would decrease a lot of complexity and increase maintainability, and I think is well worth the minor effort to do this. Dropping support will also discourage developers from running b2g desktop locally (I assume this is a good thing). I'm filing this because if we don't drop support, I'm going to have to do some extra work due to bug 1219442.
Just going to tackle mochitest for now, as mulet and b2g_desktop actually share a lot of code in reftest for some reason (so it's not as easy to simply gut b2g desktop). I'll file a follow-up for reftest, though may punt on working on it.
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Component: General → Mochitest
Summary: Drop support for b2g desktop in mochitest and reftest harnesses → Drop support for b2g desktop in mochitest
Bug 1225903 - Drop support for b2g desktop in mochitest, r=jgriffin B2G desktop is no longer being run on any trunk branches, including b2g-inbound. Dropping support for it significantly reduces complexity in the mochitest harness.
Attachment #8689526 - Flags: review?(jgriffin)
Here's some working try runs: https://email@example.com&fromchange=2c2fbf78ff54&tochange=15c8b2c0b83f The diff makes the changes look more complicated than they are. All that happened in runtests.py was to rename MochitestUtilsMixin -> MochitestBase, rename Mochitest -> MochitestDesktop, and move some functions that b2g uses out of MochitestDesktop and into MochitestBase. In runtestsb2g, all that happened was B2GDesktopMochitest got deleted, and B2GDeviceMochitest got merged with B2GMochitest.
Also forgot to mention I talked to gwagner on irc and got the green light for this.
Comment on attachment 8689526 [details] MozReview Request: Bug 1225903 - Drop support for b2g desktop in mochitest, r=jgriffin https://reviewboard.mozilla.org/r/25657/#review23109 Yay for deleting dead code.
Attachment #8689526 - Flags: review?(jgriffin) → review+
I had to back this out for apparently breaking robocop on android: https://treeherder.mozilla.org/logviewer.html#?job_id=17553901&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/d69c0607d8b1
Sorry about that. I didn't realize robocop got pulled out of runtestsremote.py and completely missed the new runrobocop.py file and then robocop didn't get selected by '-u mochitests' on try. Here's a try run that should have the issue fixed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=47a217067ba1
Comment on attachment 8689526 [details] MozReview Request: Bug 1225903 - Drop support for b2g desktop in mochitest, r=jgriffin Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25657/diff/1-2/
You need to log in before you can comment on or make changes to this bug.