Closed Bug 1225911 Opened 8 years ago Closed 8 years ago

Typo in tabbrowser.xml, incorrect usage of boolean-and when binary-and was intended

Categories

(Core Graveyard :: Security: UI, defect)

Product:
Core Graveyard
Component:
Security: UI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox46 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox46 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch for checkin
1.53 KB, patch
jaws
: review+
Details | Diff | Splinter Review
Flags: needinfo?(dao)
Attached patch Obvious fix (obsolete) — — Splinter Review 
This is the obvious fix, but Felipe or Dao should test that the behavior with the fix is correct, and what bug might have gone unnoticed before. Probably good to have a test for this. (not assigning to myself as someone may want to write a test for this and that will be 99% of the work for this bug)
Flags: needinfo?(dao)
Attachment #8689079 - Flags: review?(dao)
Attachment #8689079 - Flags: review?(dao) → review+
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: needinfo?(felipc)
Keywords: checkin-needed
Hi, this failed to apply:

applying 1225911.patch
patching file browser/base/content/tabbrowser.xml
Hunk #1 FAILED at 760
1 out of 1 hunks FAILED -- saving rejects to file browser/base/content/tabbrowser.xml.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 1225911.patch
Flags: needinfo?(jaws)
Keywords: checkin-needed

        Attachment #8689079 -
        Attachment is obsolete: true
Flags: needinfo?(jaws)

        Attachment #8707478 -
        Flags: review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/8a2d17f7f3d1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago

          status-firefox46:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.