Closed
Bug 1225963
Opened 9 years ago
Closed 9 years ago
Make color picker prettier
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(firefox45 fixed)
RESOLVED
FIXED
Firefox 45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: ntim, Assigned: ntim)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
1.47 KB,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
|
40.93 KB,
image/png
|
Details |
picker.png
The styling of the color picker is a bit ugly right now. Let's improve it.
|
Assignee | |
Updated•9 years ago
|
Blocks: dt-color-tooltip
|
|
Assignee | |
Comment 1•9 years ago
|
||
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8689184 [details] [diff] [review] Patch Review of attachment 8689184 [details] [diff] [review]: ----------------------------------------------------------------- I like those changes. Tested locally on Win10. I did see 2 problems though, but they also exist without your patch, just mentioning them because you might know what's going on: - the eye-dropper icon is all stretched out, or something (see attached screenshot), - the alpha channel slider shows some diagonal lines on the checkerboard background, maybe that's just a Win thing.
Attachment #8689184 -
Flags: review?(pbrosset) → review+
|
|
||
Comment 3•9 years ago
|
||
|
|
Assignee | |
Comment 4•9 years ago
|
||
(In reply to Patrick Brosset [:pbrosset] [:pbro] from comment #2) > Comment on attachment 8689184 [details] [diff] [review] > Patch > > Review of attachment 8689184 [details] [diff] [review]: > ----------------------------------------------------------------- > > I like those changes. Tested locally on Win10. > I did see 2 problems though, but they also exist without your patch, just > mentioning them because you might know what's going on: > - the eye-dropper icon is all stretched out, or something (see attached > screenshot), Bug 1225967 > - the alpha channel slider shows some diagonal lines on the checkerboard > background, maybe that's just a Win thing. This issue predates this patch.
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 5•9 years ago
|
||
(In reply to Tim Nguyen [:ntim] from comment #4) > > - the alpha channel slider shows some diagonal lines on the checkerboard > > background, maybe that's just a Win thing. > This issue predates this patch. In the color swatch not the picker*
|
||
Comment 7•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a31988cee0ed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
|
||
Updated•7 years ago
|
No longer blocks: dt-color-tooltip
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•