1226002 - Memory leaks in ssl_gtest support classes

Status: NEW

(NSS :: Test, defect, P3)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

I found some memory leaks in the ssl_gtest I/O helper classes while trying to understand how they work with respect to lifetimes / pointers.

Specifically, I was confused by DummyClose until I realized that it leaks both the PRFileDesc and the DummyPrSocket.  The latter is a little tricky, because the DummyPrSocket could also be the peer_ of another still-live file.  (Also, that should maybe be in the PRFileDesc::dtor callback and not the close method, if I understand correctly?)  If it doesn't matter enough to fix, a comment that the leak is deliberate might be helpful.

Also, Poller leaks everything in the timers_ queue; this is trivial to fix.