1226003 - Stop using MaybeRejectBrokenly in DetailedPromise

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This pattern:

   RefPtr<DOMException> exception =
     DOMException::Create(aArg, aReason);
   Promise::MaybeRejectBrokenly(exception);

can be written as:

   ErrorResult rv;
   rv.ThrowDOMException(aArg, aReason);
   Promise::MaybeReject(rv);

Comment 1

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Sorry, totally forgot about this. Will change it in the morning.

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: 1226003.patch

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8689504 [details] [diff] [review]
1226003.patch

r=me

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ac32f442f29

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6ac32f442f29