Closed Bug 1226017 Opened 4 years ago Closed 4 years ago

Drop support for b2g desktop in reftest

Categories

(Testing :: Reftest, defect)

defect
Not set

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(1 file)

We no longer run b2g desktop reftests on any trunk branches, they have been replaced by mulet. We should remove support for b2g desktop from the harness to reduce complexity and increase maintainability. Unlike mochitest, b2g desktop and mulet share a bunch of the same code on reftest, so this is slightly more complicated, but not by too much.
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Bug 1226017 - Drop support for b2g desktop in reftests, r=jgriffin
As per note in the mochitest bug, got go ahead to do this from gwagner on irc.
Does this include cleaning up any fails-if()/skip-if()/etc. annotations in reftest.list files that are specific to B2G desktop?  (It looks like there aren't many, since B2G annotations seem to cover both B2G and B2G desktop.  Then again, there are lots of skip-if() annotations that might have been put in for failures on one but not both... and since they're skip-if() rather than fails-if(), we never learn when it's time to remove them.)
Good call, I'll get those out of there and update the manifest sandbox.
Comment on attachment 8693065 [details]
MozReview Request: Bug 1226017 - Drop support for b2g desktop in reftests, r=jgriffin

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26383/diff/1-2/
Attachment #8693065 - Flags: review?(jgriffin)
Comment on attachment 8693065 [details]
MozReview Request: Bug 1226017 - Drop support for b2g desktop in reftests, r=jgriffin

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26383/diff/2-3/
Attachment #8693065 - Flags: review?(jgriffin) → review+
Comment on attachment 8693065 [details]
MozReview Request: Bug 1226017 - Drop support for b2g desktop in reftests, r=jgriffin

https://reviewboard.mozilla.org/r/26383/#review24085

Nice!
https://hg.mozilla.org/mozilla-central/rev/7029581094a4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.