Closed
Bug 1226019
Opened 9 years ago
Closed 8 years ago
Modify signing-workers to look for scopes like `project:releng:signing:..`
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: rail)
References
Details
Attachments
(1 file)
48 bytes,
text/x-github-pull-request
|
kmoir
:
review+
rail
:
checked-in+
|
Details | Review |
This puts `releng` nicely in the scope name so that it's easy to spot and anyone modifying scopes has a big red "THINK CAREFULLY ABOUT THIS" flag (just like IT won't touch anything with "releng" in the hostname.. good sides and bad sides to that..) This also avoids the inevitable name collision when some other user of TaskCluster wants to build a tool that involves signing things. I mean, we're obviously the most important, but we should be nice :) It should be relatively simple to grant anything that currently has signing:foo the project:releng:signing:foo scope, then modify signing workers to check for the latter, then remove the signing:foo scopes form task definitions, and once those tasks have completed, remove them from the roles.
Reporter | ||
Comment 1•8 years ago
|
||
Rail, is this something you could bang out at some point?
Flags: needinfo?(rail)
Assignee | ||
Comment 2•8 years ago
|
||
Sure. Do we have any deadlines?
Assignee: nobody → rail
Flags: needinfo?(rail)
Reporter | ||
Comment 3•8 years ago
|
||
Nope, just a "this should get done" thing.
Reporter | ||
Comment 4•8 years ago
|
||
Woo, I just saw this get merged -- do you need help changing any existing roles or clients?
Assignee | ||
Comment 5•8 years ago
|
||
it's a intermediate change to accept both scopes. so far we have only 2 consumers: https://github.com/mozilla/funsize/blob/master/funsize/tasks/funsize.yml https://github.com/mozilla/releasetasks/tree/master/releasetasks/templates Shouldn't be hard to find-and-replace once this is deployed. I'd rather steal your brain in bug 1252365 ;)
Assignee | ||
Comment 6•8 years ago
|
||
I created a new client ID for funsize: project/releng/funsize/production and deployed it
Assignee | ||
Comment 7•8 years ago
|
||
Attachment #8726209 -
Flags: review?(kmoir)
Assignee | ||
Comment 8•8 years ago
|
||
Forgot to change the config: http://hg.mozilla.org/build/puppet/rev/f1848ca95e61
Updated•8 years ago
|
Attachment #8726209 -
Flags: review?(kmoir) → review+
Assignee | ||
Updated•8 years ago
|
Attachment #8726209 -
Flags: checked-in+
Assignee | ||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•