1226020 - NotificationHelper closeOnClick regression

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[heidi.kasemir]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.86 Safari/537.36

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] hkasemir:1226020-closeonclick-regression > mozilla-b2g:master

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8689222 [details] [review]
[gaia] hkasemir:1226020-closeonclick-regression > mozilla-b2g:master

James, Shawn, while working on bug 1111841 Heidi migrated two cases from Notification API to use NotificationHelper.

One consequence of that switch is that NotificationHelper by default adds "closeOnClick" behavior. Becuase in the original code there was no click handler in those two calls, this patch adds "closeOnClick: false" to remove the unintended behavior change.

Could you please review this patch?

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #2)
> Comment on attachment 8689222 [details] [review]
> [gaia] hkasemir:1226020-closeonclick-regression > mozilla-b2g:master
> 
> James, Shawn, while working on bug 1111841 Heidi migrated two cases from
> Notification API to use NotificationHelper.
> 
> One consequence of that switch is that NotificationHelper by default adds
> "closeOnClick" behavior. Becuase in the original code there was no click
> handler in those two calls, this patch adds "closeOnClick: false" to remove
> the unintended behavior change.
> 
> Could you please review this patch?

Hi,
Sorry, I'm not sure this is my domain.

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Hi,
Sorry, I'm not sure this is not my domain. Can you confirm again?

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

According to https://wiki.mozilla.org/Modules/FirefoxOS you're an owner of Bluetooth module. The patch touches ./apps/bluetooth so I assumed you'll be the right person to review it.

Can you point the right person if that's not you?

Comment 6

[[e-mail]]

please resolve the unit test error before merge

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/c2d090af1b37ce942025e2725930ea035376b063