1226077 - Make dummy promotion list in app deck better

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[Evelyn Hung]

There are a few dummy banners to fill up promotion list space, let make these them more meaningful.

The polish is just for building a better simulator version, no need to cherry pick by partner.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] evelynhung:issue-1226077 > mozilla-b2g:master

Comment 2

[Evelyn Hung]

Comment on attachment 8689316 [details] [review]
[gaia] evelynhung:issue-1226077 > mozilla-b2g:master

In this patch, I replaced the promotion list on App Deck with some links we want to highlight.

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8689316 [details] [review]
[gaia] evelynhung:issue-1226077 > mozilla-b2g:master

Is this for checking-in to master?

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8689316 [details] [review]
[gaia] evelynhung:issue-1226077 > mozilla-b2g:master

r=me
But some banner pictures are enlarged that makes the screen looks ugly... We may need to ask UX to polish them later.

Comment 5

[Evelyn Hung]

(In reply to KM Lee [:rexboy] from comment #3)
> Comment on attachment 8689316 [details] [review]
> [gaia] evelynhung:issue-1226077 > mozilla-b2g:master
> 
> Is this for checking-in to master?

yes, master only.

Comment 6

[Evelyn Hung]

(In reply to KM Lee [:rexboy] from comment #4)
> Comment on attachment 8689316 [details] [review]
> [gaia] evelynhung:issue-1226077 > mozilla-b2g:master
> 
> r=me
> But some banner pictures are enlarged that makes the screen looks ugly... We
> may need to ask UX to polish them later.

I'm not sure if this is worth bothering our visual team since they are just dummies and will be replaced by partners. :/
needinfo UX team to get their opinions.

@Tori, I was thinking these picture are just for building simulator. Then I also think it's better to make it consistent in the codebase. That's why I filed this bug.

Comment 7

[Evelyn Hung]

Attachment: FirefoxOS.png

Banner picture for Firefox OS webpage.

Comment 8

[Evelyn Hung]

Attachment: participationHub.png

Banner picture of TV Participation Hub.

Comment 9

[Evelyn Hung]

Attachment: tvMDN.png

Banner picture of TV MDN page.

Comment 10

[Tori Chen [:tori]]

Attachment: appdeck_promotion.zip

Hi Evelyn, please check the images.

Comment 11

[Tori Chen [:tori]]

Attachment: appdeck_promotion.zip

update image for "participation hub"

Comment 12

[Evelyn Hung]

Thanks Tori. I found the background image width and height is calculated(resized) dynamically, I didn't count it right. The height of the promotion space is fixed as 486px but the width will be actual window size. Not sure how to manage this case, so I decided to use the icon image (which is in a proper w/h ratio) first. :-(

Comment 13

[Evelyn Hung]

Merged into master:
https://github.com/mozilla-b2g/gaia/commit/7298a264cdbc1b8e810b49fe2b05798a91abd591