Closed Bug 1226077 Opened 7 years ago Closed 7 years ago

Make dummy promotion list in app deck better

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jj.evelyn, Assigned: jj.evelyn)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(5 files, 1 obsolete file)

There are a few dummy banners to fill up promotion list space, let make these them more meaningful.

The polish is just for building a better simulator version, no need to cherry pick by partner.
Assignee: nobody → ehung
Comment on attachment 8689316 [details] [review]
[gaia] evelynhung:issue-1226077 > mozilla-b2g:master

In this patch, I replaced the promotion list on App Deck with some links we want to highlight.
Attachment #8689316 - Flags: review?(rexboy)
Comment on attachment 8689316 [details] [review]
[gaia] evelynhung:issue-1226077 > mozilla-b2g:master

Is this for checking-in to master?
Comment on attachment 8689316 [details] [review]
[gaia] evelynhung:issue-1226077 > mozilla-b2g:master

r=me
But some banner pictures are enlarged that makes the screen looks ugly... We may need to ask UX to polish them later.
Attachment #8689316 - Flags: review?(rexboy) → review+
(In reply to KM Lee [:rexboy] from comment #3)
> Comment on attachment 8689316 [details] [review]
> [gaia] evelynhung:issue-1226077 > mozilla-b2g:master
> 
> Is this for checking-in to master?

yes, master only.
(In reply to KM Lee [:rexboy] from comment #4)
> Comment on attachment 8689316 [details] [review]
> [gaia] evelynhung:issue-1226077 > mozilla-b2g:master
> 
> r=me
> But some banner pictures are enlarged that makes the screen looks ugly... We
> may need to ask UX to polish them later.

I'm not sure if this is worth bothering our visual team since they are just dummies and will be replaced by partners. :/
needinfo UX team to get their opinions.

@Tori, I was thinking these picture are just for building simulator. Then I also think it's better to make it consistent in the codebase. That's why I filed this bug.
Flags: needinfo?(tchen)
Attached image FirefoxOS.png
Banner picture for Firefox OS webpage.
Attached image participationHub.png
Banner picture of TV Participation Hub.
Attached image tvMDN.png
Banner picture of TV MDN page.
Attached file appdeck_promotion.zip (obsolete) —
Hi Evelyn, please check the images.
Flags: needinfo?(tchen) → needinfo?(ehung)
Attached file appdeck_promotion.zip
update image for "participation hub"
Attachment #8689403 - Attachment is obsolete: true
Thanks Tori. I found the background image width and height is calculated(resized) dynamically, I didn't count it right. The height of the promotion space is fixed as 486px but the width will be actual window size. Not sure how to manage this case, so I decided to use the icon image (which is in a proper w/h ratio) first. :-(
Flags: needinfo?(ehung)
Merged into master:
https://github.com/mozilla-b2g/gaia/commit/7298a264cdbc1b8e810b49fe2b05798a91abd591
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.