1226133 - [Homescreen]The right pin page is overflowed and shown incompletely.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Shally Li（leave from Mozilla）]

[1.Description]:
[Aries KK v2.5&2.6][Flame KK v2.5&2.6][Homescreen]When adding more than one pin page to homescreen on landscape mode, the pin pages on the right side of this column on homescreen will be overflowed and shown incompletely.

Found at: 11:46
Attach: Flame_v2.6.3gp and logcat_1146.txt

[2.Testing Steps]: 
1. Open a website by Browser.
2. Pin this page to homescreen.
3. Open another website.
4. Tap "..." menu -> tap "Pin" -> tap "Pin page" on landscape mode (Important).
5. Press Home button and observe the web pages on homescreen.

[3.Expected Result]: 
5. All pin pages on the homescreen shows completely and normally.

[4.Actual Result]: 
5. The right pin page on the homescreen is overflowed and shown incompletely.

[5.Reproduction build]: 
Device: Flame KK 2.5 512mb user build (affected)
Build ID               20151119010236
Gaia Revision          28d63cf3bdc4417f7ad8cab2230f096bf9f6d3b5
Gaia Date              2015-11-17 07:35:12
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/afcf8a4b4cf310edd0e442fa80506d5cce291666
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151119.001411
Firmware Date          Thu Nov 19 00:14:20 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK v2.6 512mb (master) user build (affected)
Build ID               20151118150206
Gaia Revision          cba7e4b86361af31b153cfebaf99900e0b860f7b
Gaia Date              2015-11-18 09:45:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1d6155d7e6c91fa5ec1ef6927f3d3a044187896d
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151118.184136
Firmware Date          Wed Nov 18 18:41:48 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK v2.6 512mb (master) eng build (affected)
Build ID               20151118150206
Gaia Revision          cba7e4b86361af31b153cfebaf99900e0b860f7b
Gaia Date              2015-11-18 09:45:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1d6155d7e6c91fa5ec1ef6927f3d3a044187896d
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151118.184005
Firmware Date          Wed Nov 18 18:40:17 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5  user build (affected)
Build ID               20151119010651
Gaia Revision          28d63cf3bdc4417f7ad8cab2230f096bf9f6d3b5
Gaia Date              2015-11-17 07:35:12
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/afcf8a4b4cf310edd0e442fa80506d5cce291666
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151119.001315
Firmware Date          Thu Nov 19 00:13:23 UTC 2015
Bootloader             s1

Device: Aries KK 2.6 (master) user build (affected)
Build ID               20151118145707
Gaia Revision          cba7e4b86361af31b153cfebaf99900e0b860f7b
Gaia Date              2015-11-18 09:45:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1d6155d7e6c91fa5ec1ef6927f3d3a044187896d
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151118.141704
Firmware Date          Wed Nov 18 14:17:11 UTC 2015
Bootloader             s1


[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Shally Li（leave from Mozilla）]

Attachment: Flame_v2.6.3gp

Comment 2

[Shally Li（leave from Mozilla）]

Attachment: logcat_1146.txt

Comment 3

[Chris Lord [:cwiiis]]

This should be fixed by bug 1214388, but a small change should guarantee against this happening, I'll make that change.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1226133-homescreen-synchronise-pages-on-resize > mozilla-b2g:master

Comment 5

[Alberto Pastor [:albertopq]]

Comment on attachment 8689513 [details] [review]
[gaia] Cwiiis:bug1226133-homescreen-synchronise-pages-on-resize > mozilla-b2g:master

r+ overall, but left a nit in GH. Thanks!

Comment 6

[Chris Lord [:cwiiis]]

Addressed nit in comment I think, can always change later. Merged: https://github.com/mozilla-b2g/gaia/commit/157aa0d93e6a48c182c100871e411ce82c72179d

Comment 7

[Chris Lord [:cwiiis]]

Comment on attachment 8689513 [details] [review]
[gaia] Cwiiis:bug1226133-homescreen-synchronise-pages-on-resize > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Possible to get the pinned pages panel into a weird layout that can be non-obvious how to recover from.
[Testing completed]: Tested manually, added a unit test.
[Risk to taking this patch] (and alternatives if risky): Very low risk.
[String changes made]: None.

Comment 8

[Mahendra Potharaju [:mahe]]

Comment on attachment 8689513 [details] [review]
[gaia] Cwiiis:bug1226133-homescreen-synchronise-pages-on-resize > mozilla-b2g:master

Approved for 2.5 uplift. 

Thanks

Comment 9

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame 2.6(master) and Aires KK 2.6(master) by the STR in comment 0.

Actual results: the pin pages on the right side of this column on homescreen are not overflowed. 
See attachment: verified_Aries_v2.6.3gp
Reproduce rate: 0/10


Device: Aries KK 2.6(master) (Pass)
Build ID               20151124014704
Gaia Revision          ea673b5c4cc19c3daca072691a659c68e4c6937f
Gaia Date              2015-11-23 16:41:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/19d89caa664dd9309c796929225ee409df5d1ee4
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151124.005529
Firmware Date          Tue Nov 24 00:55:36 UTC 2015
Bootloader             s1

Device: Flame 2.6(master) 512mb (Pass)
Build ID               20151124013632
Gaia Revision          ea673b5c4cc19c3daca072691a659c68e4c6937f
Gaia Date              2015-11-23 16:41:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/19d89caa664dd9309c796929225ee409df5d1ee4
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151124.005539
Firmware Date          Tue Nov 24 00:55:49 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 10

[Shally Li（leave from Mozilla）]

Attachment: verified_Aries_v2.6.3gp

Comment 11

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/b9eb09a57d644653ccfa3b6c0f07b73bf76cf7b1

Comment 12

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: the pin pages on the right side of this column on homescreen are not overflowed. 
See above attachment: "verified_Aries_v2.6.3gp"
Reproduce rate: 0/10


Device: Aries KK v2.5 (Pass)
Build ID               20151125233358
Gaia Revision          93b8bf2de3258c25199d97036c50a87667059148
Gaia Date              2015-11-25 10:29:48
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/a883c12a75da3fa58b64bcb94923b013c71f546a
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151125.224212
Firmware Date          Wed Nov 25 22:42:20 UTC 2015
Bootloader             s1

Device: Flame 2.5 (512mb) (Pass)
Build ID               20151125234005
Gaia Revision          93b8bf2de3258c25199d97036c50a87667059148
Gaia Date              2015-11-25 10:29:48
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/a883c12a75da3fa58b64bcb94923b013c71f546a
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151125.224957
Firmware Date          Wed Nov 25 22:50:06 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0