1226165 - NameError: global name 'android_ndk_url' is not defined

Status: RESOLVED DUPLICATE of bug 1227600

(Firefox Build System :: Mach Core, enhancement)

Description

[Florian Quèze [:florian]]

This on an up to date (9b28207cf3e3) fx-team tree.

After editing osx.py to replace:
            self.ndk_url = android_ndk_url('darwin')
with:
            self.ndk_url = 'https://dl.google.com/android/ndk/android-ndk-r10e-darwin-x86_64.bin'

mach bootstrap completed successfully.

Here is the full output:

$ ./mach bootstrap

Please choose the version of Firefox you want to build:
1. Firefox for Desktop
2. Firefox for Android
Your choice:
2

Looks like you have Homebrew installed. We will install all required packages via Homebrew.

Error running mach:

    ['bootstrap']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

NameError: global name 'android_ndk_url' is not defined

  File "/Users/florian/buildhg/fx-android/python/mozboot/mozboot/mach_commands.py", line 23, in bootstrap
    bootstrapper.bootstrap()
  File "/Users/florian/buildhg/fx-android/python/mozboot/mozboot/bootstrap.py", line 137, in bootstrap
    getattr(self.instance, 'install_%s_packages' % application)()
  File "/Users/florian/buildhg/fx-android/python/mozboot/mozboot/osx.py", line 192, in install_mobile_android_packages
    getattr(self, 'ensure_%s_mobile_android_packages' % self.package_manager)()
  File "/Users/florian/buildhg/fx-android/python/mozboot/mozboot/osx.py", line 358, in ensure_homebrew_mobile_android_packages
    self.ndk_url = android_ndk_url('darwin')

Comment 1

[Mark Goodwin [:mgoodwin]]

This affects me on Linux as well. I think I see what's up here.

Comment 2

[Mark Goodwin [:mgoodwin]]

Attachment: MozReview Request: Bug 1226165 - fix android ndk issues in mach boostrap r?glandium

Bug 1226165 - fix android ndk issues in mach boostrap r?glandium

Comment 3

[Mark Goodwin [:mgoodwin]]

Florian, if this isn't too late to help you, I can confirm the above fix works (for me) on OS X.

Comment 4

[Florian Quèze [:florian]]

(In reply to Mark Goodwin [:mgoodwin] from comment #3)
> Florian, if this isn't too late to help you, I can confirm the above fix
> works (for me) on OS X.

It's too late to help me, but thanks on behalf of the next person who would run into it if it wasn't being fixed :-).

Comment 5

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8692460 [details]
MozReview Request: Bug 1226165 - fix android ndk issues in mach boostrap r?glandium

Fix has landed, so no need for review.