1226166 - Move apps/system/js/places.js to /shared so other apps can reuse it

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Michiel de Jong [:michielbdejong]]

Prerequisite / first part of the work for bug 1208352

Comment 1

[Michiel de Jong [:michielbdejong]]

Moving functions:

* getStore
* defaultPlace
* editPlace
* setVisits
* setPinned
* isPinned
* addToVisited
* saveScreenshot
* saveThemeColor
* clearHistory (except for LazyLoader wrapper)
* addVisit (except for onLocationChange LazyLoader wrapper)
* setTitle (except for onTitleChange LazyLoader wrapper)
* setIcon (except for onIconChange LazyLoader wrapper)
* debounce
* debouncePlacesChanges

Not moving functions:

* _start (related to Module)
* handleEvent (related to Module)
* screenshotRequested (uses Service)
* takeScreenshot (not related to places)
* checkTopSites (uses asyncStorage)
* clearHistory (LazyLoader wrapper)
* onLocationChange (LazyLoader wrapper for addVisit)
* onTitleChange (LazyLoader wrapper for setTitle)
* onIconChange (LazyLoader wrapper for setIcon)

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] michielbdejong:1226166-move-systems-places-to-shared > mozilla-b2g:master

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] michielbdejong:1226166-move-systems-editPlaces-to-shared > mozilla-b2g:master

Comment 4

[Michiel de Jong [:michielbdejong]]

Comment on attachment 8690029 [details] [review]
[gaia] michielbdejong:1226166-move-systems-editPlaces-to-shared > mozilla-b2g:master

Hi Dale,

In the end I left the debounce part in systems and moved only editPlace to /shared.

Can you give some early feedback to let me know if I'm on the right track?

I still need to fix the MockLazyLoader problem, move the relevant unit tests so that they're next to the code in shared, and clean up the loose ends.

Comment 5

[Dale Harvey (:daleharvey)]

Comment on attachment 8690029 [details] [review]
[gaia] michielbdejong:1226166-move-systems-editPlaces-to-shared > mozilla-b2g:master

This looks great, no further comments :)

Comment 6

[Michiel de Jong [:michielbdejong]]

Comment on attachment 8689527 [details] [review]
[gaia] michielbdejong:1226166-move-systems-places-to-shared > mozilla-b2g:master

Obsolete.

Comment 7

[BMO Automation]

Firefox OS is not being worked on