two improvement I have in my tree for a while: 1) When a cached compose window get reopen, we shoudl make sure it get removed from the cache even when it get reopen improperly. 2) When closing a window, if the cache is already full but does not contains a window of the same type of the one we are closing, the new one must replace the old one in the cache. That will make the cache more usefull when a user switch from plaintext compose to html compose and vice versa. Else, imagine you are first posting couple news message, the cache will be filled with plain text compose window and therefore you want be able to use the advantage of the recycled window for composing HTML email message.
Status: NEW → ASSIGNED
Summary: Better habdling of the Recycled Compose Cache → Better handling of the Recycled Compose Cache
Whiteboard: Have fix
Target Milestone: --- → mozilla0.9.9
Comment on attachment 67101 [details] [diff] [review] Proposed fix, v1 r=cavin.
Attachment #67101 - Flags: review+
Comment on attachment 67101 [details] [diff] [review] Proposed fix, v1 is it safe to not own a ref count on domWindow when we access it from mCachedWindows[i].window? .window isn't returning an addrefed dom window is it? sr=mscott
Attachment #67101 - Flags: superreview+
You are right Scott, I should use a COMPtr. I'll fix that before check it in...
Fixed and checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Esther, I am changing this bug to be yours. Let me know if you think I should be verifying this bug.
QA Contact: sheelar → esther
QA Contact: esther → stephend
Jean-Francois - can I verify this at the code level (it got two really good reviews from peers). I don't see how I can verify this with any standard testcase without stepping through code and examining variable scope/values.
The only thing you can verify without looking at the code it the improvement #2.
Right, so the scenario to test would be like this, then: In HTML compose mode, click "Compose". Close window. Click "Compose". Close window. Click SHIFT-"Compose" (which now brings up plain text). Close window. Click SHIFT-"Compose" (which now brings up a cached plain text window). Correct?
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.9) Gecko/20020311 Netscape6/6.2.1+ Mozilla/5.0 (Windows; U, Windows NT 5.0; en-US; rv:0.9.9) Gecko/20020312 Netscape6/6.2.1+ Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US, rv:0.9.9) Gecko/20020310 Verified FIXED on the branch, now to the trunk.
Verified FIXED on the trunk now with: Mac OS X 10.1.3 - build 2002-03-14-08 RedHat 7.2 - build 2002-03-14-08 Windows 2K - build 2002-03-14-03
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.