Closed Bug 1226264 Opened 10 years ago Closed 7 years ago

Hard to add general review comments while reviewing a diff in mozreview

Categories

(MozReview Graveyard :: General, defect)

Product:
MozReview Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: bzbarsky, Unassigned)

Details

Today I was reviewing a largish patch in mozreview and in addition to the line by line comments I had general questions not applicable to particular lines but prompted by things I was reading. The workflow for that was pretty sucky. I had two options, afaict: 1) Click the "Finish Review" button (even though I'm totally not finished), type my text into the textbox above/below all the line notes in that view, "Save", go back to the diff, find my spot again. 2) Just take notes in a separate editor window, then later paste them into the review textfields when I did actually get to the "Finish Review" part. I ended up doing #2, obviously.
Yeah it's not great. Maybe we could add a comment box above or below the diff.
Product: Developer Services → MozReview
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.