1226280 - Add support for quick gmail actions to tryserver emails

Status: NEW

(Release Engineering :: General, enhancement, P5)

Description

[Dave Townsend [:mossop]]

Attachment: patch

I rarely need to see the contents of the initial try email, I just need to get the link to the test results. Gmail provides a way to include metadata in emails to add custom buttons to the email list view for quick linking to websites (https://developers.google.com/gmail/markup/reference/go-to-action). It would be awesome to support this in tryserver emails.

The attached patch is a WIP to do this. It adds support for multipart emails to ChangeNotifier since we have to send a html message to include the metadata. The try email generator builds a text and html body, the html body includes gmail actions for getting to the builds and the results.

Are there any tests for this stuff?

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8689636 [details] [diff] [review]
patch

Review of attachment 8689636 [details] [diff] [review]:
-----------------------------------------------------------------

There are no tests for this unfortunately. I took the patch for a spin on a build scheduler on my laptop, and it didn't barf at runtime, but the mail didn't actually make it out (local issues). I'll need to set up an instance on a linux box like dev-master instead.

::: status/generators.py
@@ +89,4 @@
>      return msgdict
>  
> +def includesTalos(titles):
> +    allTitles = '\n'.join(commitTitles)

s/commitTitle/titles/.

Comment 2

[Ed Morley [:emorley]]

It's worth noting that to get these buttons to actually show up in GMail, you have to go through a whitelisting process with Google. One of their requirements for acceptance is a reasonable throughput of emails - I'm not sure what counts as a reasonable throughput, but try emails may not qualify (compared to say bugmails). If you're happy to put the effort in even if they end up declining, it's worth a try anyway :-)

(I went through the process when I added similar support to bugmails, and they took several months to accept and deploy the whitelisting entry).

Comment 3

[Dave Townsend [:mossop]]

(In reply to Ed Morley (Away, back 23rd Nov) [:emorley] from comment #2)
> It's worth noting that to get these buttons to actually show up in GMail,
> you have to go through a whitelisting process with Google. One of their
> requirements for acceptance is a reasonable throughput of emails - I'm not
> sure what counts as a reasonable throughput, but try emails may not qualify
> (compared to say bugmails). If you're happy to put the effort in even if
> they end up declining, it's worth a try anyway :-)

Hrm that blows. I can't see any reference to it in the email markup reference though, where do I go to start the process?

Comment 4

[Ed Morley [:emorley]]

They've changed the docs page since I enrolled; the new design isn't that helpful - the only reference to registering I can see if "register with google" on the sidebar. Previously they emphasised it in the main how-to guides too.

https://developers.google.com/gmail/markup/registering-with-google

Comment 5

[Dave Townsend [:mossop]]

(In reply to Dave Townsend [:mossop] from comment #3)
> (In reply to Ed Morley (Away, back 23rd Nov) [:emorley] from comment #2)
> > It's worth noting that to get these buttons to actually show up in GMail,
> > you have to go through a whitelisting process with Google. One of their
> > requirements for acceptance is a reasonable throughput of emails - I'm not
> > sure what counts as a reasonable throughput, but try emails may not qualify
> > (compared to say bugmails). If you're happy to put the effort in even if
> > they end up declining, it's worth a try anyway :-)
> 
> Hrm that blows. I can't see any reference to it in the email markup
> reference though, where do I go to start the process?

Never mind, found it. https://developers.google.com/gmail/markup/registering-with-google

Looks like we might have enough volume, I saw about 200 try runs triggered over the past day, almost all to mozilla.com addresses so hitting 100 a day like it suggests seems doable.

I'm happy to do some legwork to test this out though one of the requirements involves sending an email from production to google so that would be hard for me to do. And I also need an example email to verify it is working correctly first and since I don't know how to test this that will be hard :(

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Sorry, I haven't had a chance to run this on a staging master, but perhaps you can find someone willing to give it a go. I'm don't know if try emails will still exist after things get migrated to taskcluster; it's pretty strongly integrated with buildbot right now.

Comment 7

[Julien Cristau [:jcristau]]

The try emails still exist after the taskcluster migration:
https://searchfox.org/mozilla-central/rev/daedd554ae8a2c7f420ad77311134c8c298ba318/.taskcluster.yml#318-326