1226311 - Remove SpecialPowers.isMainProcess() tests from IndexedDB

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Andrew McCreight [:mccr8]]

There are a number of tests in the dom/indexedDB/test/ directory that detect if they are running in the main process, and if they are, they just don't do anything. All of that code should be removed and replaced with skip-if annotations in the mochitest.ini file, so that it is easier to tell that these tests don't do anything.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Remove some obsolete includes for test_ipc.html in indexeddb.

test_ipc.html doesn't seem to exist any more.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=40e3120ca1d8

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Remove SpecialPowers.isMainProcess usage from various IndexedDB tests.

isMainProcess() is used in a few places to disable tests when run in a
content process. However, these tests are either never run in e10s or
pass when run with e10s, so remove all of the testing code. Some of
this was to work around issues with test_ipc.html which does not seem
to exist any more.

This patch also removes some code for disabling a test on Windows 2003.

Comment 3

[Jan Varga [:janv]]

Comment on attachment 8691645 [details] [diff] [review]
part 1 - Remove some obsolete includes for test_ipc.html in indexeddb.

Review of attachment 8691645 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[Jan Varga [:janv]]

Comment on attachment 8691646 [details] [diff] [review]
part 2 - Remove SpecialPowers.isMainProcess usage from various IndexedDB tests.

Review of attachment 8691646 [details] [diff] [review]:
-----------------------------------------------------------------

The try push has some problems but it seems it's not related to these two patches.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/44d659497cb9
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5d820b790a0

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/44d659497cb9
https://hg.mozilla.org/mozilla-central/rev/f5d820b790a0