122636 - Templatise colchange.cgi

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement)

Description

[David Lawrence [:dkl]]

I have created a templatised version of colchange.cgi with colchange.tmpl template.
Attaching patch for review.

Comment 1

[David Lawrence [:dkl]]

Attachment: Patch to templatise colchange.cgi (v1)

Comment 2

[Christian Reis]

Comment on attachment 67110 [details] [diff] [review]
Patch to templatise colchange.cgi (v1)

>+$template->process("buglist/colchange.tmpl", $vars)
>+  || DisplayError("Template process failed: " . $template->error())
>+  && exit;

Well, have we decided that the default extension is .tmpl? I thought it was
.html.tmpl or something?

>+<select name="splitheader">
>+<option value="0" [% "SELECTED" IF ! splitheader %]>Normal headers (prettier)
>+<option value="1" [% "SELECTED" IF splitheader %]>Stagger headers (often makes list more compact)
>+</select>

Please change this to a radiobutton with <LABEL>s around the text descriptions.
The option menu for 2 options
makes no sense and requires more clicks. Yeah, I know this isn't in the
description, but why not make things
better with a 4-line change? :-)

With that confirmed, r=kiko

Comment 3

[David Lawrence [:dkl]]

Attachment: Patch for templatising of colchange.cgi (v2)

Made changes suggested by kiko.

Comment 4

[Christian Reis]

Attachment: kiko_addon_v1: with this addon, I r=kiko the original patch.

This patch should be applied _over_ dkl's patch. The issue is that I can't do a
cvs add without write access, and so I can't produce a proper patch. 

All it does is add <label> support to the columns themselves, which is really
nice. It's a 4-liner.

Comment 5

[Christian Reis]

Comment on attachment 67145 [details] [diff] [review]
Patch for templatising of colchange.cgi (v2)

r=kiko with my addon

Comment 6

[Jacob Steenhagen]

Comment on attachment 67145 [details] [diff] [review]
Patch for templatising of colchange.cgi (v2)

Works for me...
r=jake

Comment 7

[Jacob Steenhagen]

Comment on attachment 67291 [details] [diff] [review]
kiko_addon_v1: with this addon, I r=kiko the original patch.

I like <label> tags :)
r=jake

Comment 8

[Jacob Steenhagen]

-> Patch author

Comment 9

[Jacob Steenhagen]

Checked in.

Comment 10

[Dave Miller [:justdave]]

fixing incorrect milestones on fixed bugs.