1226454 - [Aries] Portrait only apps going show app previews in landscape mode using task manager.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Task Manager, defect)

Description

[Sxean Lee-David [:sxean]]

Description:
Where some apps are designed only for portrait mode, they will go into landscape mode when there are browser windows open and flip to landscape view.

Repro Steps:
1) Update a Aries to 20151119162551
2) open a variety of apps and websites to and view with taskmanager in portrait mode. 
3) switch to landscape mode starting with a website. 
4) observe

Actual:
all apps, game and websites going into landscape mode when using the taskmanager. 

Expected:
all apps, games and websites stay in portrait mode regardless of intended orientation when using taskmanager. 

Notes: this happens most when there are more than a dozen open events such as a game, several websites, email client, phone app, etc,...

Environmental Variables:
Device: Aries 2.6
Build ID: 20151119162551
Gaia: ffaade435bb9c3005fd6c9b7ee1cd17b90e08cbf
Gecko: a523d4c7efe2f43dd6b25a176c07b729918d550f
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Repro frequency: (5/5)
See attached: (video clip, logcat)

NO REPRO on the following builds:  

Environmental Variables:
Device: Aries 2.5
BuildID: 20151119161838
Gaia: 28d63cf3bdc4417f7ad8cab2230f096bf9f6d3b5
Gecko: 497118efc1414c2825a8bd17b38721888c3875ca
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 44.0a2 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Environmental Variables:
Device: Flame 2.6
BuildID: 20151119030229
Gaia: cba7e4b86361af31b153cfebaf99900e0b860f7b
Gecko: 1d6155d7e6c91fa5ec1ef6927f3d3a044187896d
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Environmental Variables:
Device: Flame 2.5
BuildID: 20151119161153
Gaia: 28d63cf3bdc4417f7ad8cab2230f096bf9f6d3b5
Gecko: 497118efc1414c2825a8bd17b38721888c3875ca
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0a2 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20151119032505
Gaia: 885647d92208fb67574ced44004ab2f29d23cb45
Gecko: e772f343b736
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 1

[Sxean Lee-David [:sxean]]

Attachment: portrait landscape.txt

Comment 2

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue only affects app previews in Task Manager itself.  I don't think this is a blocker, but can I get your opinion Alison?

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Looking closer at this bug, it does not occur on 2.5 because Landscape mode task manager is not implemented in 2.5 yet.  This is not a regression as it came with the change to make task manager function in landscape mode.

Comment 4

[Sam Foster [:sfoster] (he/him)]

(In reply to Jayme Mercado [:JMercado] from comment #3)
> Looking closer at this bug, it does not occur on 2.5 because Landscape mode
> task manager is not implemented in 2.5 yet.  This is not a regression as it
> came with the change to make task manager function in landscape mode.

Did I miss that? I don't see a commit which enables landscape mode for task manager, and https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/task_manager_utils.js#L71 should have the effect that for phones and other portrait-primary orientation devices the task manager is locked to portrait. And for the time being I'm not aware of a supported landscape-primary device or use case for the task manager. If you are able to put task manager into landscape mode I think *that* is a regression, ironically as its a much requested feature.

Comment 5

[Alison Shiue]

According to comment 4, I think we need to find the regression window for the landscape task manager.

Comment 6

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

I was actually thinking of bug 1174325 which I thought had been resolved Sam.  Guess I was mistaken.

Comment 7

[Marcus Cavanaugh [:mcav]]

I can't reproduce despite having many apps open. The STR states that this happened 5/5 times, but the comment also says this happens most often when many apps are open. Does it not reproduce when only a few are open? Can you provide a video showing this, starting from when you have no apps open, and then opening the apps that cause it to reproduce?

Comment 8

[Sxean Lee-David [:sxean]]

(In reply to Marcus Cavanaugh [:mcav] from comment #7)
> I can't reproduce despite having many apps open. The STR states that this
> happened 5/5 times, but the comment also says this happens most often when
> many apps are open. Does it not reproduce when only a few are open? Can you
> provide a video showing this, starting from when you have no apps open, and
> then opening the apps that cause it to reproduce?

You can have several apps and/or just the game SWOOP with a website running, while viewing the website switch to Landscape Mode. At that point, long press the SHB to go into Task Manager Mode and observe that all apps go into Landscape Mode. 

See new video showing only SWOOP and website here: 

https://youtu.be/F-d0IfCFF-w

Comment 9

[Max Murrell [MMurrell]]

I'm able to repro this consistently by Aries and Flame 2.6 but not at all with Flame 2.5. As mentioned in comment 8 I can repro 100% of the time by entering landscape mode while browsing a website then opening the task manager. The taskmanager will initially default to portrait mode but you can go back to landscape by reorienting the device to portrait then back to landscape.

Comment 10

[Max Murrell [MMurrell]]

I'm unable to get a regression window do to an inconsistent repro-rate. The repro rate decreases from what seems like 100% to something close to 5% 

Below is the earliest build that reproduced the bug. 
Environmental Variables: Repro 2/25
Device: Flame 2.6
BuildID: 20151116172907
Gaia: 9473dbcbebf4e758a3b73200968efc69071b4312
Gecko: d1a8f65dbf479db6960b5c56ca9102839d0d561e
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D

Comment 11

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

The repro rate is unfortunately too low to get a valid regression window for this issue.

Comment 12

[Carrie.Yang Leave from Mozilla]

This bug can also be repro on latest build of Aries KK v2.5 by the STR in comment 0.
Actual results: All apps and websites going into landscape mode when using the task manager. 
See attacthments: Aries_v2.5.3gp and logcat_1029.txt.
Reproduce rate: 10/10.

Device：Aries KK v2.5 (Affected)
Build ID               20151201171338
Gaia Revision          e05621cbfd92b3fb4e5aef86621c57cd68fb0414
Gaia Date              2015-12-01 15:07:53
Gecko Revision         http://hg.mozilla.org/releases/mozilla-
b2g44_v2_5/rev/89b4f90d2865e62b9d898655cf082902cf2572a0
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151201.161919
Firmware Date          Tue Dec  1 16:19:27 UTC 2015
Bootloader             s1

Comment 13

[Carrie.Yang Leave from Mozilla]

Attachment: Aries_v2.5.3gp

Comment 14

[Carrie.Yang Leave from Mozilla]

Attachment: logcat_1029.txt

Comment 16

[Sam Foster [:sfoster] (he/him)]

Can we try and get a window again. See bug 1231895 for alternate steps

Comment 17

[John Thomas [:Johnt]]

Caused by changes made in Bug 1131470

Mozilla Inbound Regression Window

Last Working
Environmental Variables:
Device: Flame 2.5
BuildID: 20150818201141
Gaia: 1e1197e0e8e64307aa382ffba4711d1c661de7ca
Gecko: 4203e86db40a2fdcc52fa2f6ca263a1d9d704b91
Version: 43.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

First Broken
Environmental Variables:
Device: Flame 2.5
BuildID: 20150818201542
Gaia: 1e1197e0e8e64307aa382ffba4711d1c661de7ca
Gecko: be65c38abed995c7975383836c87df21ac02bcc7
Version: 43.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Last Working gaia / First Broken gecko - This issue DOES occur with broken Gecko
Gaia: 1e1197e0e8e64307aa382ffba4711d1c661de7ca
Gecko: be65c38abed995c7975383836c87df21ac02bcc7

Last Working gecko / First Broken gaia - This issue does NOT occur with broken Gaia
Gecko: 4203e86db40a2fdcc52fa2f6ca263a1d9d704b91
Gaia: 1e1197e0e8e64307aa382ffba4711d1c661de7ca

Mozilla Inbound Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=4203e86db40a2fdcc52fa2f6ca263a1d9d704b91&tochange=be65c38abed995c7975383836c87df21ac02bcc7

Comment 18

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

William and Sam, this issue seems to have been caused by the changes for bug 1131470.  Can you please take a look?

Comment 19

[Sam Foster [:sfoster] (he/him)]

(In reply to Jayme Mercado [:JMercado] from comment #18)
> William and Sam, this issue seems to have been caused by the changes for bug
> 1131470.  Can you please take a look?

Thanks for figuring this out. Looks like we need to update to implement the unprefixed https://w3c.github.io/screen-orientation/

Comment 21

[William Chen [:wchen]]

(In reply to John Thomas [:Johnt] from comment #17)
> Caused by changes made in Bug 1131470
> First Broken
> Environmental Variables:
> Device: Flame 2.5
> BuildID: 20150818201542
> Gaia: 1e1197e0e8e64307aa382ffba4711d1c661de7ca
> Gecko: be65c38abed995c7975383836c87df21ac02bcc7
> Version: 43.0a1 (2.5) 
> Firmware Version: v18D
> User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0
How often were you able to reproduce in this configuration? I've tried reproducing with these changesets as well as the changesets in comment 0 without being able to hit the bug.

Comment 22

[John Thomas [:Johnt]]

I have not been able to repro the reporter's bug using steps listed in Comment 0. However, I was able to reproduce this issue specifically using the steps listed in bug 1231895 as referenced from Comment 16. I have been able to skip step 3.

The steps were as follows:
1. Launch Email app.
2. Input name and Email address, tap next.
3. Tap power button twice.
4. Rotate device to landscape.
5. Tap next, slide up and down the view.

Environmental Variables:
Device: Flame 2.6
BuildID: 20151216030223
Gaia: a84c2dbe672583914d04380cd61a56f1c60c3b8e
Gecko: 0babaa3edcf908c393b68a3dc2d1c2a2450c31ed
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 46.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Comment 23

[Sam Foster [:sfoster] (he/him)]

I'm not going to have time to work on this before the holidays. The new orientation API has an async screen.lock() which returns a promise, so this is a bit more involved than a search/replace. To be clear, screen.mozLockOrientation doesnt work any more as of gecko 43.

Comment 24

[BMO Automation]

Firefox OS is not being worked on