Closed Bug 1226479 Opened 5 years ago Closed 5 years ago

Remove the requirement to pass string pointers to ThrowTypeError/ThrowRangeError

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

Just takes a bit more Forward and rvalue refs.
Comment on attachment 8689907 [details] [diff] [review]
Change ErrorResult::ThrowTypeError/ThrowRangeError to take string references, not pointers

Review of attachment 8689907 [details] [diff] [review]:
-----------------------------------------------------------------

Out of curiousity, what's the goal here? Just avoiding the finickyness of & at these call sites? Or is there some other benefit?
Attachment #8689907 - Flags: review?(continuation) → review+
> Just avoiding the finickyness of & at these call sites?

Yep.  And slightly the fact that some consumers apparently felt like they had to make copies of the strings to take pointer to them...
https://hg.mozilla.org/mozilla-central/rev/c0eab88b18c2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.