1226523 - Fennec crashes after transferring bookmarks and history

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: First Run, defect)

Description

[Bingqing Li]

Environments:
-------------------------------
Fennec 43.0 beta 4
GT-N5110
Android 4.1.2


Description:
-------------------------------
Fennec crashed after transferring the bookmarks and history


Crash reports:
-------------------------------
https://crash-stats.mozilla.com/report/index/1933ce74-f81c-4825-b45d-ad0a32151120

Comment 1

[:Margaret Leibovic]

Chenxia, can you look into this? Maybe we just need to add a null check.

java.lang.NullPointerException
	at org.mozilla.gecko.preferences.AndroidImport.run(AndroidImport.java:183)
	at org.mozilla.gecko.firstrun.ImportPanel$4.run(ImportPanel.java:154)
	at android.os.Handler.handleCallback(Handler.java:615)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:43)

Comment 2

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1226523 - Fennec crashes after transferring bookmarks and history. r=margaret

Bug 1226523 - Fennec crashes after transferring bookmarks and history. r=margaret

Comment 3

[Chenxia Liu [:liuche]]

We're missing a null cursor check here - this was the code added to import from Samsung devices, but I never tested it on a device where the user has never opened the default Samsung browser.

Comment 4

[:Margaret Leibovic]

Comment on attachment 8690871 [details]
MozReview Request: Bug 1226523 - Fennec crashes after transferring bookmarks and history. r=margaret

https://reviewboard.mozilla.org/r/25981/#review23411

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: Crash with a fix

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/11a75b65a0f5

Comment 7

[Chenxia Liu [:liuche]]

Comment on attachment 8690871 [details]
MozReview Request: Bug 1226523 - Fennec crashes after transferring bookmarks and history. r=margaret

Approval Request Comment
[Feature/regressing bug #]: bug 1186037 needed an extra null check
[User impact if declined]: For Samsung S4 users who have never opened the stock browser but who want to import bookmarks/history, they will see a crash on first run
[Describe test coverage new/current, TreeHerder]: local testing 
[Risks and why]: low, add a null check
[String/UUID change made/needed]: none

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/11a75b65a0f5

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8690871 [details]
MozReview Request: Bug 1226523 - Fennec crashes after transferring bookmarks and history. r=margaret

Crash fix for first run, simple fix, ok to uplift to aurora and beta.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/91b7f25540f0

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/26eda42c6254

Comment 12

[u549602]

Verified as fixed on all builds: Nightly 45.0a1 2015-11-26, Aurora 44.0a2 2015-11-27 and Beta 7 43.0b7.
This issue was tested on Samsung Galaxy tab 2 with Android 4.2.2

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Fabulous. Thank you for the verification. Tracking in case this reopens.

Comment 14

[Bingqing Li]

Fennec still crashes after transferring bookmarks and history, but it seems like a different cause， so I filed another bug to track the crash.

Pls refer to https://bugzilla.mozilla.org/show_bug.cgi?id=1232608

Comment 15

[Bingqing Li]

Attachment: log-samsung

I can still see the crash on Android 4.1.2(Samsung GT-N5110), so I attached the log here in case we miss anything.