Closed
Bug 1226569
Opened 10 years ago
Closed 10 years ago
Use MediaEventSource to publish MetadataLoaded and FirstFrameLoaded events
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
Details
Attachments
(2 files)
This help reduce bi-directional dependency between MediaDecoder and MDSM.
Assignee | ||
Comment 1•10 years ago
|
||
Bug 1226569. Part 1 - Use MediaEventSource to publish MetadataLoaded and FirstFrameLoaded events. r=jya.
Attachment #8690612 -
Flags: review?(jyavenard)
Assignee | ||
Comment 2•10 years ago
|
||
Bug 1226569. Part 2 - assert functions that should never be called after shutdown. r=jya.
Attachment #8690613 -
Flags: review?(jyavenard)
Updated•10 years ago
|
Attachment #8690612 -
Flags: review?(jyavenard) → review+
Comment 3•10 years ago
|
||
Comment on attachment 8690612 [details]
MozReview Request: Bug 1226569. Part 1 - Use MediaEventSource to publish MetadataLoaded and FirstFrameLoaded events. r=jya.
https://reviewboard.mozilla.org/r/25885/#review23279
::: dom/media/MediaDecoderStateMachine.h:227
(Diff revision 1)
> + MediaEventSourceExc<nsAutoPtr<MediaInfo>,
what does the Exc stand for?
Updated•10 years ago
|
Attachment #8690613 -
Flags: review?(jyavenard) → review+
Comment 4•10 years ago
|
||
Comment on attachment 8690613 [details]
MozReview Request: Bug 1226569. Part 2 - assert functions that should never be called after shutdown. r=jya.
https://reviewboard.mozilla.org/r/25887/#review23281
Comment 5•10 years ago
|
||
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Jean-Yves Avenard [:jya] from comment #3)
> Comment on attachment 8690612 [details]
> MozReview Request: Bug 1226569. Part 1 - Use MediaEventSource to publish
> MetadataLoaded and FirstFrameLoaded events. r=jya.
>
> https://reviewboard.mozilla.org/r/25885/#review23279
>
> ::: dom/media/MediaDecoderStateMachine.h:227
> (Diff revision 1)
> > + MediaEventSourceExc<nsAutoPtr<MediaInfo>,
>
> what does the Exc stand for?
Thanks.
https://hg.mozilla.org/mozilla-central/file/abbd213422a560f1180c4ec6e3bf4792c2ea81ba/dom/media/MediaEventSource.h#l481
Exc means "Exclusive" where event data are moved instead of being copied to allow types that are movable only.
Comment 8•10 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/41052f93dd23
https://hg.mozilla.org/mozilla-central/rev/4bde3398d568
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jwwang
You need to log in
before you can comment on or make changes to this bug.
Description
•