1226569 - Use MediaEventSource to publish MetadataLoaded and FirstFrameLoaded events

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

This help reduce bi-directional dependency between MediaDecoder and MDSM.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1226569. Part 1 - Use MediaEventSource to publish MetadataLoaded and FirstFrameLoaded events. r=jya.

Bug 1226569. Part 1 - Use MediaEventSource to publish MetadataLoaded and FirstFrameLoaded events. r=jya.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1226569. Part 2 - assert functions that should never be called after shutdown. r=jya.

Bug 1226569. Part 2 - assert functions that should never be called after shutdown. r=jya.

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8690612 [details]
MozReview Request: Bug 1226569. Part 1 - Use MediaEventSource to publish MetadataLoaded and FirstFrameLoaded events. r=jya.

https://reviewboard.mozilla.org/r/25885/#review23279

::: dom/media/MediaDecoderStateMachine.h:227
(Diff revision 1)
> +  MediaEventSourceExc<nsAutoPtr<MediaInfo>,

what does the Exc stand for?

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8690613 [details]
MozReview Request: Bug 1226569. Part 2 - assert functions that should never be called after shutdown. r=jya.

https://reviewboard.mozilla.org/r/25887/#review23281

Comment 5

[Jean-Yves Avenard [:jya]]

https://reviewboard.mozilla.org/r/25887/#review23283

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

(In reply to Jean-Yves Avenard [:jya] from comment #3)
> Comment on attachment 8690612 [details]
> MozReview Request: Bug 1226569. Part 1 - Use MediaEventSource to publish
> MetadataLoaded and FirstFrameLoaded events. r=jya.
> 
> https://reviewboard.mozilla.org/r/25885/#review23279
> 
> ::: dom/media/MediaDecoderStateMachine.h:227
> (Diff revision 1)
> > +  MediaEventSourceExc<nsAutoPtr<MediaInfo>,
> 
> what does the Exc stand for?

Thanks.

https://hg.mozilla.org/mozilla-central/file/abbd213422a560f1180c4ec6e3bf4792c2ea81ba/dom/media/MediaEventSource.h#l481

Exc means "Exclusive" where event data are moved instead of being copied to allow types that are movable only.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41052f93dd23
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bde3398d568

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/41052f93dd23
https://hg.mozilla.org/mozilla-central/rev/4bde3398d568