Closed Bug 1226617 Opened 6 years ago Closed 6 years ago

failure in test-bugzilla-review-flag-cleared.t

Categories

(MozReview Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dminor, Assigned: dminor)

Details

Attachments

(1 file)

We have an intermittent failure in hgext/reviewboard/tests/test-bugzilla-review-flag-cleared.t:
@@ -276,9 +276,9 @@
       flags:
       - id: 2
         name: review
-        requestee: reviewer@example.com
-        setter: author@example.com
-        status: '?'
+        requestee: null
+        setter: reviewer@example.com
+        status: +
       id: 1
       is_obsolete: false
       is_patch: false
Assignee: nobody → glob
as per irc, this is no longer intermittent due to bug 1224167.
Assignee: glob → dminor
Summary: intermittent failure in test-bugzilla-review-flag-cleared.t → failure in test-bugzilla-review-flag-cleared.t
This went from intermittent to permafail when I fixed Bug 1224167 - I just didn't notice, because I was used to it failing :/

I'll fix the test.
Status: NEW → ASSIGNED
Summary: failure in test-bugzilla-review-flag-cleared.t → intermittent failure in test-bugzilla-review-flag-cleared.t
Summary: intermittent failure in test-bugzilla-review-flag-cleared.t → failure in test-bugzilla-review-flag-cleared.t
testing: fix test-bugzilla-review-flag-cleared.t (bug 1226617) r=glob

This went from intermittent to permafail in bug 1224167. This updates the
expected results to reflect the new behaviour.
Attachment #8692007 - Flags: review?(glob)
Comment on attachment 8692007 [details]
MozReview Request: testing: fix test-bugzilla-review-flag-cleared.t (bug 1226617) r=glob

https://reviewboard.mozilla.org/r/26215/#review23679

ship it!
Attachment #8692007 - Flags: review?(glob) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.