1226617 - failure in test-bugzilla-review-flag-cleared.t

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Dan Minor [:dminor]]

We have an intermittent failure in hgext/reviewboard/tests/test-bugzilla-review-flag-cleared.t:
@@ -276,9 +276,9 @@
       flags:
       - id: 2
         name: review
-        requestee: [e-mail]
-        setter: [e-mail]
-        status: '?'
+        requestee: null
+        setter: [e-mail]
+        status: +
       id: 1
       is_obsolete: false
       is_patch: false

Comment 1

[:glob ✱]

as per irc, this is no longer intermittent due to bug 1224167.

Comment 2

[Dan Minor [:dminor]]

This went from intermittent to permafail when I fixed Bug 1224167 - I just didn't notice, because I was used to it failing :/

I'll fix the test.

Comment 3

[Dan Minor [:dminor]]

Attachment: MozReview Request: testing: fix test-bugzilla-review-flag-cleared.t (bug 1226617) r=glob

testing: fix test-bugzilla-review-flag-cleared.t (bug 1226617) r=glob

This went from intermittent to permafail in bug 1224167. This updates the
expected results to reflect the new behaviour.

Comment 4

[:glob ✱]

Comment on attachment 8692007 [details]
MozReview Request: testing: fix test-bugzilla-review-flag-cleared.t (bug 1226617) r=glob

https://reviewboard.mozilla.org/r/26215/#review23679

ship it!