Closed
Bug 1226645
Opened 9 years ago
Closed 9 years ago
Rename files to better reflect use
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.6 S2 - 12/4
People
(Reporter: cwiiis, Assigned: cwiiis)
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
Some files in homescreen's names now don't properly reflect the app structure. Specifically, app.js is no longer the entire app and is just the apps panel - it should be renamed to apps.js to match pages.js (which is the equivalent for the pages panel) metadata.js only covers metadata for the apps panel - after bug 1222069, we will have a similar class for the pages panel, so we should rename this appsmetadata.js to reflect that. This is going to make rebasing in the future painful, but I think homescreen is in a good state now with respect to bugs/blockers such that this is probably the best time before we start with major feature development.
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Updated•9 years ago
|
Attachment #8690153 -
Flags: review?(apastor)
|
||
Updated•9 years ago
|
Whiteboard: [systemsfe]
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8690153 [details] [review] [gaia] Cwiiis:bug1226645-homescreen-rename-files > mozilla-b2g:master Makes sense. Thanks!
Attachment #8690153 -
Flags: review?(apastor) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 3•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/188e31d96bff123e8474ece970abdec8c1ccb727
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S2 - 12/4
You need to log in
before you can comment on or make changes to this bug.
Description
•