Closed Bug 1226661 Opened 4 years ago Closed 4 years ago

Sprinkle `this.` in client JSMs for B2G-like environments

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(firefox45 fixed)

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → jryans
Blocks: 1226422
Status: NEW → ASSIGNED
Bug 1226661 - DevTools client JSM global tweak for B2G. r=ochameau
Attachment #8690175 - Flags: review?(poirot.alex)
Comment on attachment 8690175 [details]
MozReview Request: Bug 1226661 - DevTools client JSM global tweak for B2G. r=ochameau

https://reviewboard.mozilla.org/r/25787/#review23305

You know it is going to break anytime someone with a clear mind is *not* going to bind symbols to `this`?
I'm pretty sure this b2g specific behavior is fixable at platform level,
but I'm not sure you want to dive into xpconnect :-o
Attachment #8690175 - Flags: review?(poirot.alex) → review+
(In reply to Alexandre Poirot [:ochameau] from comment #3)
> You know it is going to break anytime someone with a clear mind is *not*
> going to bind symbols to `this`?
> I'm pretty sure this b2g specific behavior is fixable at platform level,
> but I'm not sure you want to dive into xpconnect :-o

I know, but it seems to impact JSMs the most, and we shouldn't be adding more of them, so it's probably fine.
https://hg.mozilla.org/mozilla-central/rev/10973adc0c3e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.