Closed Bug 1226687 Opened 10 years ago Closed 10 years ago

Use stable hashing and builtin sweeping for JSObject2JSObjectMap

Categories

(Core :: JavaScript: GC, defect)

Product:
Core
Component:
JavaScript: GC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

Details

Attachments

(2 files)

export_GCPolicy_Heap-v0.diff
8.86 KB, patch
fitzgen
: review+
Details | Diff | Splinter Review
stable_JSObject2JSObjectMap-v0.diff
3.98 KB, patch
mccr8
: review+
Details | Diff | Splinter Review
With our new GC tools, we can simplify this tremendously.
Attachment #8690181 - Flags: review?(sphink)
Attachment #8690181 - Flags: review?(sphink) → review?(nfitzgerald)
Attachment #8690185 - Flags: review?(continuation)
Comment on attachment 8690185 [details] [diff] [review] stable_JSObject2JSObjectMap-v0.diff Review of attachment 8690185 [details] [diff] [review]: ----------------------------------------------------------------- Nice. I won't try to understand the old code. ;)
Attachment #8690185 - Flags: review?(continuation) → review+
Comment on attachment 8690181 [details] [diff] [review] export_GCPolicy_Heap-v0.diff Review of attachment 8690181 [details] [diff] [review]: ----------------------------------------------------------------- This is one of those things where you look at it and it looks like it doesn't actually do anything and then you have a few changes that all look like they don't do anything and then everything is different and better. I mean this in a good way, if that isn't clear :P \o/
Attachment #8690181 - Flags: review?(nfitzgerald) → review+
The cgc failure on windows are because I'm missing JS_PUBLIC_API in the template expansion. Fixed locally.
https://hg.mozilla.org/integration/mozilla-inbound/rev/648d35597456e37b3976c3640c0fa02e0e9b868b Bug 1226687 - Part 1: Export a GCPolicy usable by JS::Heap; r=fitzgen https://hg.mozilla.org/integration/mozilla-inbound/rev/cbb186b4d0cc398b1d1103fdd25f1b69aa217d0b Bug 1226687 - Part 2: Use stable hashing and builtin sweep for JSObject2JSObjectMap; r=mccr8
https://hg.mozilla.org/mozilla-central/rev/648d35597456 https://hg.mozilla.org/mozilla-central/rev/cbb186b4d0cc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: