Enable most requestsync tests with e10s

RESOLVED FIXED in Firefox 45

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

(Blocks: 1 bug)

Trunk
mozilla45
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10s+, firefox45 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
With bug 1226291, it is easy to get these tests to work: you just have to ensure that RequestSyncService.jsm is loaded in the main process. test_basic_app.html remains disabled because it still fails, but I assume it is just failing like all mozapps tests fail with e10s.
(Assignee)

Comment 1

3 years ago
Created attachment 8690970 [details] [diff] [review]
part 1 - Use importInMainProcess in requestsync tests.

This makes them work with e10s.

The importInMainProcess patch got backed out for Android failures, so
this will have to wait until that can land, but otherwise this looked
fine on Try.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e209567bc24
Attachment #8690970 - Flags: review?(amarchesini)
(Assignee)

Comment 2

3 years ago
Created attachment 8690971 [details] [diff] [review]
part 2 - Make geolocation mozSettings tests fail slightly less with e10s.

They still do not pass, but now they fail instead of just timing out.
Attachment #8690971 - Flags: review?(amarchesini)
Attachment #8690970 - Flags: review?(amarchesini) → review+
Attachment #8690971 - Flags: review?(amarchesini) → review+
Blocks: 984139
tracking-e10s: --- → +
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/efcfd5d6abbf
https://hg.mozilla.org/mozilla-central/rev/9c0499a3aacc
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.