Closed
Bug 1226799
Opened 9 years ago
Closed 9 years ago
De-duplicate the 11 Is[BuiltinName] self-hosting intrinsics with templates
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: till, Assigned: till)
Details
Attachments
(1 file)
|
15.32 KB,
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
So very satisfying.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8690300 -
Flags: review?(arai.unmht)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8690300 [details] [diff] [review] De-duplicate the 11 Is[BuiltinName] self-hosting intrinsics with templates Review of attachment 8690300 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, with 2 copy-n-paste fix. ::: js/src/vm/SelfHosting.cpp @@ +1503,3 @@ > IntrinsicIsMapIterator), > + JS_INLINABLE_FN("IsStringIterator", > + intrinsic_IsInstanceOfBuiltin<ArrayIteratorObject>, 1,0, StringIteratorObject @@ +1561,5 @@ > CallNonGenericSelfhostedMethod<Is<LegacyGeneratorObject>>, 2, 0), > JS_FN("CallStarGeneratorMethodIfWrapped", > CallNonGenericSelfhostedMethod<Is<StarGeneratorObject>>, 2, 0), > > + JS_FN("IsWeakSet", intrinsic_IsInstanceOfBuiltin<TypedArrayObject>, 1,0), WeakSetObject
Attachment #8690300 -
Flags: review?(arai.unmht) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4fb114d9f1bc7dcdec02e39386b81533e75cb611 Bug 1226799 - De-duplicate the 11 Is[BuiltinName] self-hosting intrinsics with templates. r=arai
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4fb114d9f1bc
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•