Assert that keys used with GCHashTable are stable

RESOLVED FIXED in Firefox 45

Status

()

Core
JavaScript: GC
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla45
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8690316 [details] [diff] [review]
no_movable_GCHashTable-v0.diff

Now that MovableCellHasher has wide adoption, we don't have any tables that this should affect.

https://bugzilla.mozilla.org/show_bug.cgi?id=1226732
Attachment #8690316 - Flags: review?(nfitzgerald)
Comment on attachment 8690316 [details] [diff] [review]
no_movable_GCHashTable-v0.diff

Review of attachment 8690316 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8690316 - Flags: review?(nfitzgerald) → review+
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e12193c17ef81281ae8240ebef5f8f814bd7d058
Bug 1226801 - None of the GCHashMap users require movable keys; r=fitzgen

Comment 3

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e12193c17ef8
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.