Closed
Bug 1226820
Opened 10 years ago
Closed 10 years ago
SwiftData safety improvements
Categories
(Firefox for iOS :: Data Storage, defect)
Tracking
()
RESOLVED
FIXED
1.3
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
Attachments
(1 file)
Part one.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8690344 -
Flags: review?(sleroux)
Attachment #8690344 -
Flags: review?(bnicholson)
|
|
Assignee | |
Comment 2•10 years ago
|
||
This PR includes fixes for Bug 1226821.
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8690344 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1290
Looks good - just a question.
Also, what are our plans with SwiftData? I see that we keep making small changes to it, making it out of sync with the dependency version. Do we have a fork that we maintain so we can track the drift between ours and theirs?
Attachment #8690344 -
Flags: review?(sleroux) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
It's been utterly out of sync for a long time now; a very independent fork. I'm not even sure how much original code is left.
|
|
Assignee | |
Comment 5•10 years ago
|
||
3e791d5
Notably, closing the DB in my testing gets rid of the -shm and -wal files. I expect that to not always be the case.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [needs uplift]
Target Milestone: --- → 2.0
|
|
Assignee | |
Comment 6•10 years ago
|
||
v1.x: 071b78d
Whiteboard: [needs uplift]
Target Milestone: 2.0 → 1.3
|
||
Updated•10 years ago
|
Attachment #8690344 -
Flags: review?(bnicholson)
You need to log in
before you can comment on or make changes to this bug.
Description
•