1226874 - Snackbar covers newly selected tab after you swipe away bottom tab

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Comment 1

[:Margaret Leibovic]

I'm not sure what we can do about this... maybe keep some empty space at the bottom of the tabs tray such that the snack bar doesn't overlap the last tab? It seem like this would be hard to fix.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

If I'm not mistaken, we can use CoordinatorLayout to automatically scroll the tabs upward when the SnackBar appears and then scroll them down when it disappears, but it could screw with users (e.g. they try to select a tab and suddenly they all move).

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to :Margaret Leibovic from comment #1)
> I'm not sure what we can do about this... maybe keep some empty space at the
> bottom of the tabs tray such that the snack bar doesn't overlap the last
> tab? It seem like this would be hard to fix.

Agree, I'm not too worried about this since the snackbar dismisses anyway 

(In reply to Michael Comella (:mcomella) from comment #2)
> If I'm not mistaken, we can use CoordinatorLayout to automatically scroll
> the tabs upward when the SnackBar appears and then scroll them down when it
> disappears, but it could screw with users (e.g. they try to select a tab and
> suddenly they all move).

I think this is outlined in the guidelines for behaviours. But I agree "push everything up" may not be ideal for a long list of things like these tabs. It's more for a single button, etc. that would otherwise be fixed to the bottom.

I don't see it as a huge "problem" right now :\

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

There is that bug to dismiss SnackBars by swiping them away too...

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

another option would be to bring back showing the url bar at the bottom

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's look for ways to make dismissing the snackbar easier. It would be more unobtrusive if using any part of the UI dismissed the snackbar.

Comment 7

[:Margaret Leibovic]

Bug 1233467 would help fix this.

Comment 8

[:Margaret Leibovic]

(In reply to :Margaret Leibovic from comment #7)
> Bug 1233467 would help fix this.

I think this fix is good enough. I'm closing out this bug, and we can track that other bug to look to uplift it.