Closed Bug 1226879 Opened 4 years ago Closed 4 years ago

Inverting and Filtering a snapshot with allocation site breakdown results in unsorted rows

Categories

(DevTools :: Memory, defect, P1)

defect

Tracking

(firefox44 unaffected, firefox45 affected, firefox46+ fixed, firefox47+ fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox44 --- unaffected
firefox45 --- affected
firefox46 + fixed
firefox47 + fixed

People

(Reporter: jsantell, Assigned: fitzgen)

Details

Attachments

(3 files)

STR:
* Load snapshot from bug 1226878: https://bugzilla.mozilla.org/attachment.cgi?id=8690426
* Set breakdown to Allocation Site
* Type in "memory" into the filter
* Invert the tree

ER: The rows be sorted by some field
AR: The rows are unsorted (or sorted by something that I don't understand)

The snapshot was from a browser toolbox recording with allocations. No other breakdowns seem to be affected by this other than alloc site.
Has STR: --- → yes
Priority: -- → P1
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Attachment #8723202 - Flags: review?(jimb) → review+
https://hg.mozilla.org/mozilla-central/rev/5be7d7b889b7
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Comment on attachment 8723202 [details] [diff] [review]
Fix census tree sorting issue with inverted allocation stack breakdown

Approval Request Comment
[Feature/regressing bug #]: Bug 1221673
[User impact if declined]: Sorting rows in memory tool's table ridiculously wrong; hurts UX of memory tool.
[Describe test coverage new/current, TreeHerder]: New tests for this case, existing tests to prevent regresssions.
[Risks and why]: Little. Very straightforward patch only affecting a non-default devtools panel.
[String/UUID change made/needed]: None.
Attachment #8723202 - Flags: approval-mozilla-aurora?
Regression from 45, tracking an marking affected for 46.
Comment on attachment 8723202 [details] [diff] [review]
Fix census tree sorting issue with inverted allocation stack breakdown

Fix for recent regression in memory tool, adds new tests. OK to uplift.
Attachment #8723202 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
has problems during uplift:

grafting 330847:5be7d7b889b7 "Bug 1226879 - Fix census tree sorting issue with inverted allocation stack breakdown; r=jimb"
merging devtools/shared/heapsnapshot/CensusUtils.js
merging devtools/shared/heapsnapshot/census-tree-node.js
merging devtools/shared/heapsnapshot/tests/unit/xpcshell.ini
warning: conflicts while merging devtools/shared/heapsnapshot/CensusUtils.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging devtools/shared/heapsnapshot/tests/unit/xpcshell.ini! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use hg resolve and hg graft --continue)
Flags: needinfo?(nfitzgerald)
Here is a try push for the aurora version: https://treeherder.mozilla.org/#/jobs?repo=try&revision=455760560182
Flags: needinfo?(nfitzgerald)
[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments:
Test Successful.

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	        beta
User Agent 		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Rows are sorted according to the field title.

Actual Results: 
As expected
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.