1226879 - Inverting and Filtering a snapshot with allocation site breakdown results in unsorted rows

Status: RESOLVED FIXED

(DevTools :: Memory, defect, P1)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: Screen Shot 2015-11-21 at 9.05.22 AM.png

STR:
* Load snapshot from bug 1226878: https://bugzilla.mozilla.org/attachment.cgi?id=8690426
* Set breakdown to Allocation Site
* Type in "memory" into the filter
* Invert the tree

ER: The rows be sorted by some field
AR: The rows are unsorted (or sorted by something that I don't understand)

The snapshot was from a browser toolbox recording with allocations. No other breakdowns seem to be affected by this other than alloc site.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Fix census tree sorting issue with inverted allocation stack breakdown

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f4ca8122917

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5be7d7b889b7

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5be7d7b889b7

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8723202 [details] [diff] [review]
Fix census tree sorting issue with inverted allocation stack breakdown

Approval Request Comment
[Feature/regressing bug #]: Bug 1221673
[User impact if declined]: Sorting rows in memory tool's table ridiculously wrong; hurts UX of memory tool.
[Describe test coverage new/current, TreeHerder]: New tests for this case, existing tests to prevent regresssions.
[Risks and why]: Little. Very straightforward patch only affecting a non-default devtools panel.
[String/UUID change made/needed]: None.

Comment 6

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Regression from 45, tracking an marking affected for 46.

Comment 7

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8723202 [details] [diff] [review]
Fix census tree sorting issue with inverted allocation stack breakdown

Fix for recent regression in memory tool, adds new tests. OK to uplift.

Comment 8

[Carsten Book [:Tomcat]]

has problems during uplift:

grafting 330847:5be7d7b889b7 "Bug 1226879 - Fix census tree sorting issue with inverted allocation stack breakdown; r=jimb"
merging devtools/shared/heapsnapshot/CensusUtils.js
merging devtools/shared/heapsnapshot/census-tree-node.js
merging devtools/shared/heapsnapshot/tests/unit/xpcshell.ini
warning: conflicts while merging devtools/shared/heapsnapshot/CensusUtils.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging devtools/shared/heapsnapshot/tests/unit/xpcshell.ini! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use hg resolve and hg graft --continue)

Comment 9

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Aurora version: Fix census tree sorting issue with inverted allocation stack breakdown

Comment 10

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Here is a try push for the aurora version: https://treeherder.mozilla.org/#/jobs?repo=try&revision=455760560182

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2164f02d5d12

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2164f02d5d12

Comment 13

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments:
Test Successful.

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	        beta
User Agent 		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Rows are sorted according to the field title.

Actual Results: 
As expected